CVPN-1615 Remove liboqs and use WolfSSL's Kyber implementation #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
liboqs
and would instead use WolfSSL's implementation of Kyber. Since WolfSSL would officially release their Kyber/ML-KEM implementations a few months later, we would use the git patch to essentially patch their PRs on top of the 5.7.4 release.The patch consists of the commits and code changes from the following PR from WolfSSL:
Configuration for enabling ML-KEM/Kyber:
./configure --enable-kyber
./configure --enable-kyber=all,ml-kem
./configure --enable-kyber=all,original
./configure --enable-kyber=all,original,ml-kem
./configure --enable-kyber=all,ml-kem,original
Motivation and Context
Reduce external dependency, prepare migration to ML-KEM
How Has This Been Tested?
Tested with a UDP xv-helium-server with new lightway-core (aka NO LIBOQS) with
Also tested it with TCP, both uses Kyber level 5 as expected
Passes mac coverage test and other unit tests as well
Types of changes
Checklist:
main