Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI #4574

Merged
merged 3 commits into from
Aug 15, 2021
Merged

Update CI #4574

merged 3 commits into from
Aug 15, 2021

Conversation

aravindvnair99
Copy link
Member

Signed-off-by: Aravind Nair [email protected]

@elidoran
Copy link

Why not add v14.17.0 and v16.1.0 and set the nightly to v17?

@aravindvnair99
Copy link
Member Author

aravindvnair99 commented May 14, 2021

Why not add v14.17.0 and v16.1.0 and set the nightly to v17?

@elidoran 14.x is there in #4338. Last time I checked with 16, the build failed.

@dougwilson should I add 15 and 16?

Also my intention of this PR was to update existing CI and not upgrade. And also to fix an inconsistency.

Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I rebased and moved the Travis CI changes to GitHub Actions.

@dougwilson dougwilson merged commit 06d1175 into expressjs:master Aug 15, 2021
@aravindvnair99 aravindvnair99 deleted the testBench-upgrade branch August 15, 2021 06:34
nevilm-lt pushed a commit to nevilm-lt/express that referenced this pull request Mar 1, 2022
nevilm-lt pushed a commit to nevilm-lt/express that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants