build: [email protected] and [email protected]

[3imed-jaberi]

• Support Node.js 13.x.
• Support Node.js 14.x.

[dougwilson]

Thank you @3imed-jaberi ! I would suggest splitting these up into two different PRs. Part of adding a new major version of supported Node.js to our CI, we need to go through every dependency in our dependency tree and see if they are testing against that version of Node.js, or test locally against that version of Node.js. This ensures that we are actually supporting it. Many of our complicated dependencies we do not copy their test suites into Express, so we don't know if the features they are providing to Express fully function without running the test suites of those dependencies in those version of Node.js ourselves.

If you're going to make a PR, I would suggest listing out all the dependencies, then note down the version of that dependency you tested into the new major version of Node.js you're adding and if any issues were encountered or not.

[3imed-jaberi]

Thank you @3imed-jaberi ! I would suggest splitting these up into two different PRs. Part of adding a new major version of supported Node.js to our CI, we need to go through every dependency in our dependency tree and see if they are testing against that version of Node.js, or test locally against that version of Node.js. This ensures that we are actually supporting it. Many of our complicated dependencies we do not copy their test suites into Express, so we don't know if the features they are providing to Express fully function without running the test suites of those dependencies in those version of Node.js ourselves.

If you're going to make a PR, I would suggest listing out all the dependencies, then note down the version of that dependency you tested into the new major version of Node.js you're adding and if any issues were encountered or not.

@dougwilson, thank you bro again for your quick reaction with my PRs, I will do whatever you requested .. Then I will love to hear from you about opening another PR or stay here.

[dougwilson]

It's no problem! I am happy to see folks come and help with these types of tasks :) !

[3imed-jaberi]

@dougwilson, I have checked all the dependencies, most of them are the same as the previous version, and as for the dependencies that we have updated, they work fine locally.

Support through the CI:

• statuses: https://github.com/jshttp/statuses/blob/master/.travis.yml#L16
• cookie : build: [email protected] jshttp/cookie#110
• proxy-addr: build: [email protected] jshttp/proxy-addr#18
• depd: https://github.com/dougwilson/nodejs-depd/blob/master/.travis.yml#L19
• setprototypeof: deps: [email protected] #4011

[dougwilson]

I have checked all the dependencies, most of them are the same as the previous version

Thank you! To be clear, I'm not sure what you're saying if you can help me out. That seems like a very small subset of our dependencies. Does, for example, the send dependency work on Node.js 13 and 14? I didn't see you list that one, and it's one of our critical dependencies to check out.

For your check list, what did you use to determine which dependencies to list there vs not list?

[3imed-jaberi]

Bro, few minutes and I will list all others dependencies here with Node.js v14.5.0.

• send: work fine locally 🚀 ..

[dougwilson]

Hi @3imed-jaberi sorry for that! You just stated that you "have checked all the dependencies" and then since the list was incomplete, I was confused on what that meant; if you're still working on that, that's OK, but it wasn't clear that was the case. You may want to clarify if you are still in progress on something in the future :)

[dougwilson]

When you have a completed list, please feel free to ping me at that time so I can review. No need to ping me if it is still in progress :)

[3imed-jaberi]

I told you I have checked all the dependencies and I did already ..

Sorry for my english..., I wanted to let you know that I will be listing some pictures of each dependency. so that the process is clear and you can see that it really works fine locally ..

List (devDeps isn't included) :

• accepts

• array-flatten

• body-parser

• content-disposition

• cookie-signature

• content-type

• debug

• encodeurl

• escape-html

• etag

• findhandler

• fresh

• merge-descriptors

• methods

• on-finished

• parseurl

• path-to-regexp

• range parser

• serve static

• safe-buffer

• utils-merge

• vary

• type-is
  https://github.com/jshttp/type-is/blob/master/.travis.yml#L20

[aravindvnair99]

@3imed-jaberi Can be tested with v14.16 now as that's the latest.

[3imed-jaberi]

@dougwilson, Node.js have new security releases for 12.x and 10.x. so, should we upgrade to latest ?!

[aravindvnair99]

@dougwilson, Node.js have new security releases for 12.x and 10.x. so, should we upgrade to latest ?!

@3imed-jaberi I have a PR here with those changes: #4574

[3imed-jaberi]

@dougwilson, Node.js have new security releases for 12.x and 10.x. so, should we upgrade to latest ?!

@3imed-jaberi I have a PR here with those changes: #4574

cool 🚀

[dougwilson]

thank you for all the hard work you did to check the deps