Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu-bar] Remove AsyncStorage migrator #135

Merged
merged 2 commits into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

### 💡 Others

- Remove AsyncStorage migrator and @react-native-async-storage/async-storage dependency. ([#135](https://github.com/expo/orbit/pull/135) by [@gabrieldonadel](https://github.com/gabrieldonadel))

## 1.0.2 — 2024-01-17

### 🎉 New features
Expand Down
10 changes: 2 additions & 8 deletions apps/menu-bar/macos/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1059,8 +1059,6 @@ PODS:
- React-jsi (= 0.73.1)
- React-logger (= 0.73.1)
- React-perflogger (= 0.73.1)
- RNCAsyncStorage (1.19.0):
- React-Core
- RNCClipboard (1.13.1):
- React-Core
- RNSVG (13.14.0):
Expand Down Expand Up @@ -1122,7 +1120,6 @@ DEPENDENCIES:
- React-runtimescheduler (from `../../../node_modules/react-native-macos/ReactCommon/react/renderer/runtimescheduler`)
- React-utils (from `../../../node_modules/react-native-macos/ReactCommon/react/utils`)
- ReactCommon/turbomodule/core (from `../../../node_modules/react-native-macos/ReactCommon`)
- "RNCAsyncStorage (from `../../../node_modules/@react-native-async-storage/async-storage`)"
- "RNCClipboard (from `../../../node_modules/@react-native-clipboard/clipboard`)"
- RNSVG (from `../../../node_modules/react-native-svg`)
- Sparkle (~> 2.5.0)
Expand Down Expand Up @@ -1237,8 +1234,6 @@ EXTERNAL SOURCES:
:path: "../../../node_modules/react-native-macos/ReactCommon/react/utils"
ReactCommon:
:path: "../../../node_modules/react-native-macos/ReactCommon"
RNCAsyncStorage:
:path: "../../../node_modules/@react-native-async-storage/async-storage"
RNCClipboard:
:path: "../../../node_modules/@react-native-clipboard/clipboard"
RNSVG:
Expand Down Expand Up @@ -1299,14 +1294,13 @@ SPEC CHECKSUMS:
React-runtimescheduler: b4ed0e5f08dd236185b3d719c484b1d07ed69c07
React-utils: 9b1df4c7eb86a02607d61db23652559780031449
ReactCommon: 608b12d4b6d2fa209101a960a202721d33cd35b6
RNCAsyncStorage: 4b98ac3c64efa4e35c1197cb0c5ca5e9f5d4c666
RNCClipboard: 90e241893de33a2f5962fc34d76ada4576033e49
RNSVG: d00c8f91c3cbf6d476451313a18f04d220d4f396
SocketRocket: abac6f5de4d4d62d24e11868d7a2f427e0ef940d
Sparkle: 913cef92f73e08d0ae47a36ee20e523913e5f9e2
Swifter: e71dd674404923d7f03ebb03f3f222d1c570bc8e
Yoga: 5f6d85ca2ac7a018ea0ff4c3da3e5514a3f2149c
Yoga: 88f18d68738202d1be157e417a291ac59f86a77c

PODFILE CHECKSUM: a15655f397a85e92ecca3834288dddae790b0c5a

COCOAPODS: 1.13.0
COCOAPODS: 1.14.3
1 change: 0 additions & 1 deletion apps/menu-bar/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"dependencies": {
"@apollo/client": "^3.8.1",
"@expo/styleguide-native": "^1.0.1",
"@react-native-async-storage/async-storage": "^1.19.0",
"@react-native-clipboard/clipboard": "^1.13.1",
"apollo3-cache-persist": "^0.14.1",
"common-types": "1.0.0",
Expand Down
13 changes: 5 additions & 8 deletions apps/menu-bar/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { StyleSheet } from 'react-native';

import AutoResizerRootView from './components/AutoResizerRootView';
import { SAFE_AREA_FACTOR } from './hooks/useSafeDisplayDimensions';
import { PersistGate } from './modules/PersistGate';
import Popover from './popover';
import { DevicesProvider } from './providers/DevicesProvider';
import { ThemeProvider } from './providers/ThemeProvider';
Expand All @@ -18,13 +17,11 @@ function App(props: Props) {
style={styles.container}
enabled={!props.isDevWindow}
maxRelativeHeight={SAFE_AREA_FACTOR}>
<PersistGate>
<ThemeProvider themePreference="no-preference">
<DevicesProvider>
<Popover isDevWindow={props.isDevWindow} />
</DevicesProvider>
</ThemeProvider>
</PersistGate>
<ThemeProvider themePreference="no-preference">
<DevicesProvider>
<Popover isDevWindow={props.isDevWindow} />
</DevicesProvider>
</ThemeProvider>
</AutoResizerRootView>
);
}
Expand Down
48 changes: 0 additions & 48 deletions apps/menu-bar/src/modules/PersistGate.tsx

This file was deleted.

19 changes: 0 additions & 19 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2837,13 +2837,6 @@
picocolors "^1.0.0"
tslib "^2.6.0"

"@react-native-async-storage/async-storage@^1.19.0":
version "1.19.0"
resolved "https://registry.yarnpkg.com/@react-native-async-storage/async-storage/-/async-storage-1.19.0.tgz#594aca9c20924b7955d62cf43797b4187e1e6cf8"
integrity sha512-xOFkz/FaQctD6yNJDur+WnHdSTigOs3pTz6HmfC8X8PYwcnnN3R9UxuWiwsfK8vvT2WioAxUkQt3lB7GySNA2w==
dependencies:
merge-options "^3.0.4"

"@react-native-clipboard/clipboard@^1.13.1":
version "1.13.1"
resolved "https://registry.yarnpkg.com/@react-native-clipboard/clipboard/-/clipboard-1.13.1.tgz#e313110aa487c510acb9f810637a41d1d0511857"
Expand Down Expand Up @@ -7596,11 +7589,6 @@ is-plain-obj@^1.0.0, is-plain-obj@^1.1.0:
resolved "https://registry.yarnpkg.com/is-plain-obj/-/is-plain-obj-1.1.0.tgz#71a50c8429dfca773c92a390a4a03b39fcd51d3e"
integrity sha512-yvkRyxmFKEOQ4pNXCmJG5AEQNlXJS5LaONXo5/cLdTZdWvsZ1ioJEonLGAosKlMWE8lwUy/bJzMjcw8az73+Fg==

is-plain-obj@^2.1.0:
version "2.1.0"
resolved "https://registry.yarnpkg.com/is-plain-obj/-/is-plain-obj-2.1.0.tgz#45e42e37fccf1f40da8e5f76ee21515840c09287"
integrity sha512-YWnfyRwxL/+SsrWYfOpUtz5b3YD+nyfkHvjbcanzk8zgyO4ASD67uVMRt8k5bM4lLMDnXfriRhOpemw+NfT1eA==

is-plain-object@^2.0.4:
version "2.0.4"
resolved "https://registry.yarnpkg.com/is-plain-object/-/is-plain-object-2.0.4.tgz#2c163b3fafb1b606d9d17928f05c2a1c38e07677"
Expand Down Expand Up @@ -8862,13 +8850,6 @@ meow@^8.1.2:
type-fest "^0.18.0"
yargs-parser "^20.2.3"

merge-options@^3.0.4:
version "3.0.4"
resolved "https://registry.yarnpkg.com/merge-options/-/merge-options-3.0.4.tgz#84709c2aa2a4b24c1981f66c179fe5565cc6dbb7"
integrity sha512-2Sug1+knBjkaMsMgf1ctR1Ujx+Ayku4EdJN4Z+C2+JzoeF7A3OZ9KM2GY0CpQS51NR61LTurMJrRKPhSs3ZRTQ==
dependencies:
is-plain-obj "^2.1.0"

merge-stream@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/merge-stream/-/merge-stream-2.0.0.tgz#52823629a14dd00c9770fb6ad47dc6310f2c1f60"
Expand Down