Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu-bar] Remove AsyncStorage migrator #135

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Jan 15, 2024

Why

It's been months since the 1.0.0 release and we no longer need to keep this migration layer

How

  • Remove @react-native-async-storage/async-storage dependency
  • Remove PersistGate component and async storage migration logic

Test Plan

Run app locally and ensure values are being stored

@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/remove-persist-gate branch from ef74507 to 5275dc9 Compare January 17, 2024 20:51
@gabrieldonadel gabrieldonadel merged commit 967ef8e into main Jan 17, 2024
1 check passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/remove-persist-gate branch January 17, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants