Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codemention] make codemention.yml up to date #2740

Merged

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Dec 4, 2024

Why

It seems like this file includes redundant entries + is not up to date

How

Remove redundant entries, add @radoslawkrzemien to global codeowners, make @wschurman and @quinlanj codeowners of everything EAS Update related (including channel commands), remove @byCedric and @EvanBacon from EAS Update codeowners

Test Plan

Review

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic marked this pull request as ready for review December 4, 2024 16:12
@szdziedzic szdziedzic added the no changelog PR that doesn't require a changelog entry label Dec 4, 2024 — with Graphite App
Copy link

github-actions bot commented Dec 4, 2024

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link

github-actions bot commented Dec 4, 2024

Size Change: -1.78 kB (0%)

Total Size: 53 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53 MB -1.78 kB (0%)

compressed-size-action

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.51%. Comparing base (a2fe99c) to head (1687a0a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2740   +/-   ##
=======================================
  Coverage   52.51%   52.51%           
=======================================
  Files         583      583           
  Lines       22555    22555           
  Branches     4436     4436           
=======================================
  Hits        11842    11842           
  Misses      10678    10678           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic merged commit 4280e10 into main Dec 5, 2024
12 of 13 checks passed
@szdziedzic szdziedzic deleted the 12-04-_codemention_make_codemention.yml_up_to_date branch December 5, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants