Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented two-fer exercise #74

Merged
merged 2 commits into from
May 10, 2018
Merged

Implemented two-fer exercise #74

merged 2 commits into from
May 10, 2018

Conversation

herwinw
Copy link
Contributor

@herwinw herwinw commented Apr 26, 2018

This replaces the old hello-world that is simplified in #69.

This replaces the old hello-world that is simplified in #69.
@herwinw
Copy link
Contributor Author

herwinw commented Apr 26, 2018

The build fails with:

-> An implementation for 'two-fer' was found, but config.json does not reference this exercise.

If someone could review the code, then I'll figure out how to update the json file

@benreyn benreyn self-requested a review April 26, 2018 18:53
@benreyn
Copy link
Contributor

benreyn commented Apr 26, 2018

Ill take a look @herwinw. Thanks for the PR!

@benreyn
Copy link
Contributor

benreyn commented Apr 27, 2018

This looks good codewise @herwinw. Once we get the exercise added to config.json I think this should be good to merge.

@herwinw
Copy link
Contributor Author

herwinw commented May 10, 2018

Well, that was about 2 minutes of work after 30 minutes of searching (link). I've added the exercise to the bottom, it will probably need some reordering, but that should be covered in #45 since that problem is bigger than just this exercise.

@benreyn benreyn merged commit 836b32f into exercism:master May 10, 2018
@benreyn
Copy link
Contributor

benreyn commented May 10, 2018

Thanks @herwinw!

@herwinw herwinw deleted the two-fer branch May 10, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants