Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated hello-world exercise #69

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Updated hello-world exercise #69

merged 1 commit into from
Apr 27, 2018

Conversation

herwinw
Copy link
Contributor

@herwinw herwinw commented Dec 19, 2017

The problem specification has been updated to drop the optional name
argument. This resolves #34.

The problem specification has been updated to drop the optional name
argument. This resolves #34.
@herwinw
Copy link
Contributor Author

herwinw commented Dec 19, 2017

Please note that this is my first contribution to exercism, and I'm a noob with Scheme. I might have missed something very trivial ;)

@yurrriq
Copy link
Member

yurrriq commented Dec 21, 2017

Thanks for this. I’m not sure it’s the direction we want to go in, as I fundamentally changes the problem. If you want to implement Jason’s suggestion from #34. That would be great!

@herwinw
Copy link
Contributor Author

herwinw commented Dec 24, 2017

The change in behaviour is not my idea, but has been discussed "upstream", see exercism/problem-specifications#290 and exercism/problem-specifications#520 The main problem was that "Hello, World" was meant as an introductionary example, for which the variadic arguments are not really suitable in a number of languages. A new exercise has been added as a subsitute for the variadic case: exercism/problem-specifications#548 I could try to add this to this PR

@benreyn
Copy link
Contributor

benreyn commented Apr 26, 2018

Circling back on this one, based on conversations had upstream, it looks like we can probably merge this, and implement the two-fer exercise for this track

@benreyn benreyn self-requested a review April 26, 2018 18:53
@yurrriq
Copy link
Member

yurrriq commented Apr 26, 2018

Hmm. I guess this looks good to me then.

@benreyn benreyn merged commit 0baa733 into exercism:master Apr 27, 2018
@herwinw herwinw deleted the hello_world branch April 27, 2018 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hello World exercise not trivial in scheme
3 participants