-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Exercise reordering #776
Conversation
- uncore pythagorean-triplet: it's pure math, which is not what exercism is about - move core exercises to top of config.json
I had to think for a bit about how one would visualise the diff produced by this, and I think I came up with a way to do that. Define the flat representation of a config.json as follows: Write all core exercises in order, then write all side exercises alphabetically and the core exercise that unlocks it. To visualise the diff produced by this PR, diff the flat representation of the original vs new As of commit fb0a46e : $ diff -u <(ruby ../problem-specifications/tree.rb --flat <(git show master:config.json)) <(ruby ../problem-specifications/tree.rb --flat config.json)
--- /proc/self/fd/11 2018-12-17 03:53:02.372319646 +0000
+++ /proc/self/fd/12 2018-12-17 03:53:02.372319646 +0000
@@ -3,19 +3,18 @@
[deprecated] hexadecimal
[core]
hello-world
-pythagorean-triplet
+bracket-push
+atbash-cipher
saddle-points
+anagram
+space-age
+sublist
clock
luhn
-atbash-cipher
-bracket-push
-sublist
-space-age
-macros
-poker
-anagram
minesweeper
parallel-letter-frequency
+macros
+poker
forth
[side]
@@ -31,13 +30,13 @@
book-store unlocked by poker
bowling unlocked by clock
circular-buffer unlocked by minesweeper
-collatz-conjecture unlocked by pythagorean-triplet
+collatz-conjecture unlocked by luhn
crypto-square unlocked by atbash-cipher
custom-set unlocked by sublist
decimal unlocked by poker
diamond unlocked by luhn
difference-of-squares unlocked by hello-world
-diffie-hellman unlocked by pythagorean-triplet
+diffie-hellman unlocked by luhn
dominoes unlocked by poker
dot-dsl unlocked by clock
etl unlocked by clock
@@ -65,6 +64,7 @@
prime-factors unlocked by hello-world
protein-translation unlocked by anagram
proverb unlocked by hello-world
+pythagorean-triplet unlocked by luhn
queen-attack unlocked by clock
rail-fence-cipher unlocked by atbash-cipher
raindrops unlocked by hello-world
@@ -80,7 +80,7 @@
say unlocked by saddle-points
scale-generator unlocked by poker
scrabble-score unlocked by saddle-points
-series unlocked by pythagorean-triplet
+series unlocked by luhn
sieve unlocked by clock
simple-cipher unlocked by atbash-cipher
simple-linked-list unlocked by clock
|
Oh, I actually wonder whether we're really disrupting people with pythagorean triplet so early, ever since it got the new tests in #713 - the performance is now a big factor, remember how I had to do #732 to make it more reasonable. While it's a fine chance to discuss asymptotic performance, having it that early is not the best for the goal of gaining fluency. Consider this the evidence I provide in favour of the recommendation: Attempt to break off a small part of this effort that involves moving pythagorean-triplet to a more suitable place, and have it merged sooner than later. |
I expect several subsequent reorderings--I'm halfway through Round 2 of the
process, and the core team is hard at work finishing implementing the rest
of Round 2 right now. There are several more rounds sketched out.
Consequently, I'd prefer not to actually break out the pythagorean-triplet
move until we can reorder everything all at once.
Also, that's a really cool way to visualize these changes. Have you linked
to `tree.rb` elsewhere?
…On Mon, Dec 17, 2018 at 5:02 AM Peter Tseng ***@***.***> wrote:
Oh, I actually wonder whether we're really disrupting people with
pythagorean triplet so early, ever since it got the new tests in #713
<#713> - the performance is now a
big factor, remember how I had to do #732
<#732> to make it more reasonable.
While it's a fine chance to discuss asymptotic performance, having it that
early is not the best for the goal of gaining fluency.
Consider this the evidence I provide in favour of the recommendation:
Attempt to break off a small part of this effort that involves moving
pythagorean-triplet to a more suitable place, and have it merged sooner
than later.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#776 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHdeTtn8wrM3yiDl7UrA5O-nYiAokTDHks5u5xdZgaJpZM4ZOGeR>
.
|
I originally wrote it for #560 (comment) but it became so often used that I decided I needed to preserve it at https://github.com/petertseng/exercism-problem-specifications/blob/list-tracks/tree.rb Of course, back then it only supported the non-flat way of showing the track |
I like the visualisation very much! I'd like to give it to other maintainers who are working through the same process. Is that okay? |
Well, I don't see why not. The usual deals about "no warranties, express or implied" apply, as one would expect. If people don't want to receive code, perhaps at least they at willing to receive the idea. The idea is of course independent of the code. |
@maintainers/rust |
I want to get a more complete solution in before merging any of the
reorderings.
…On Tue, Jan 22, 2019 at 10:04 AM Maud de Vries ***@***.***> wrote:
@maintainers/rust
Is it possible/doable to get this reordering merged?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#776 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHdeTme1j6jAgczWc7J_gnYKcqsOi7xoks5vFtQQgaJpZM4ZOGeR>
.
|
Superseded by #804. |
Working with exercism core team on this. Feel free to comment and improve. All other track maintenance temporarily suspended while this is in progress. Estimated date of completion: 1 Feb 2019.