Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythagorean-triplet: Updated the test suite to the version 1.0.0 #713

Merged
merged 7 commits into from
Nov 16, 2018

Conversation

ZapAnton
Copy link
Contributor

Updates the pythagorean-triplet according to the latest canonical-data.

The canonical-data introduced the sum input parameter, therefore the stub template is updated alongside with the test suite and the example solution.

Closes #712

@ZapAnton
Copy link
Contributor Author

ZapAnton commented Nov 12, 2018

I may be reading the Travis logs wrong, but for some reason the exercise is checked four times. Should probably investigate this.

Edit: Indeed the git diff --name-only master | grep "exercises/" | cut -d '/' -f -2 | awk -v repo=$repo '{print repo"/"$1}' command returns something like this:

/exercises/pythagorean-triplet
/exercises/pythagorean-triplet
/exercises/pythagorean-triplet
/exercises/pythagorean-triplet

Probably worth an issue

@coriolinus
Copy link
Member

Approve of the work done so far, but a little bit remains:

I wanted to add "update README" to that list, but apparently the problem-specifications README is also out of date and misleading.

Copy link
Member

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think this looks good. Thanks for doing it!

I have not verified the tests against the canonical data, but they look reasonable.

I intend to merge this not later than Wednesday, assuming no objections from other maintainers. I do not object if other maintainers wish to merge sooner.

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I noticed something about the check. Let me know if I was wrong

@petertseng
Copy link
Member

my comment appears to have disappeared. one second while I remake it.

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I noticed something about the check. Let me know if I was wrong

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

@coriolinus coriolinus merged commit 49bda8b into exercism:master Nov 16, 2018
@ZapAnton ZapAnton deleted the pythagorean_triplet_update branch November 16, 2018 14:20
@petertseng petertseng added the sync/tests Keep a test suite/version in sync with exercism/problem-specifications label Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sync/tests Keep a test suite/version in sync with exercism/problem-specifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants