-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythagorean-triplet: Updated the test suite to the version 1.0.0 #713
pythagorean-triplet: Updated the test suite to the version 1.0.0 #713
Conversation
I may be reading the Travis logs wrong, but for some reason the exercise is checked four times. Should probably investigate this. Edit: Indeed the
Probably worth an issue |
… function with Vec
Approve of the work done so far, but a little bit remains:
I wanted to add "update README" to that list, but apparently the problem-specifications README is also out of date and misleading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think this looks good. Thanks for doing it!
I have not verified the tests against the canonical data, but they look reasonable.
I intend to merge this not later than Wednesday, assuming no objections from other maintainers. I do not object if other maintainers wish to merge sooner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I noticed something about the check. Let me know if I was wrong
my comment appears to have disappeared. one second while I remake it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I noticed something about the check. Let me know if I was wrong
…th the HashSet<[u32; 3]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense!
Updates the
pythagorean-triplet
according to the latest canonical-data.The canonical-data introduced the
sum
input parameter, therefore the stub template is updated alongside with the test suite and the example solution.Closes #712