Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protein-translation: update tests #1103

Closed
sjwarner-bp opened this issue Nov 13, 2017 · 3 comments
Closed

protein-translation: update tests #1103

sjwarner-bp opened this issue Nov 13, 2017 · 3 comments

Comments

@sjwarner-bp
Copy link
Contributor

sjwarner-bp commented Nov 13, 2017

As identified in #784, some of the exercise test-suites are out-of-date, protein-translation is one of them. It would therefore be really helpful for people to go through and update the test suite to match the canonical data.

Tests should typically be ordered according to their order in the canonical data, since this makes it easier to check and update them in future. If you think that there's a better order, please let us know your reasoning in your PR.

If there are some additional tests that currently exist in this track but which aren't in the canonical data, these can be kept if you think that they are useful. They should be placed at the bottom of the test cases, and it would also be super-helpful if you could add a comment before them saying # Additional tests for this track to make it clear that they aren't part of the canonical data.

The version string should be placed just before the first test class and followed by a blank line. For this exercise, the version string is:

# Tests adapted from problem-specifications/canonical-data.json @ v1.0.0

Test suite: /exercism/python/exercises/protein-translation/protein_translation_test.py
Canonical data: exercism/problem-specifications//exercises/protein-translation/canonical-data.json

@cmccandless
Copy link
Contributor

Since #784 is still open, I don't think we need a new issue here. It would be better to comment in #784 the list of exercises which have had canonical-data implemented since the original list of out-of-date exercises was made there.

Please close this issue and point all discussion on out-of-date tests to #784.

@N-Parsons
Copy link
Contributor

@sjwarner-bp, thanks for raising this as an issue.

@cmccandless, I disagree that this issue should be closed, so I'm going to reopen it. We have issues for all of the different exercises that need to have their tests updated, and this just follows on with that - #784 is a general issue, and this is a specific one.

@cmccandless
Copy link
Contributor

cmccandless commented Nov 13, 2017 via email

pheanex added a commit to pheanex/xpython that referenced this issue Nov 29, 2017
ErikSchierboom added a commit to ErikSchierboom/python that referenced this issue Jan 29, 2021
* Created all required files for python concept - conditionals

* [CI] Format code

* CUsed prettier to format the files

* Used prettier to format the files

* First draft of introduction.md done

* Initial draft completed on introduction.md and working on after.md

* Made first draft of after.md

* Update languages/exercises/concept/conditionals/.docs/after.md

David cleaned up Grammar issues

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

minor grammar issues fixed from davids suggestion

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

grammar corrections ahh sigh!!

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Modifications to after.md as per review
-  The modifications made at "one line if statement"
- The inital draft had mentioned about one line if statement after the example for it
-  Now the one line if statement style guide is before showing example

* Minor corrections as stated in initial review
- Chnaged the eerenious output at line 34 for elif statement

* Created the initial draft for design.md

* Modified 'config.json'
- Misinterpreted "forked-from" now removed that and ammeded the mistake

* Update languages/exercises/concept/conditionals/.docs/introduction.md

Accepting Grammar corrections from Eric

Co-authored-by: Erik Schierboom <[email protected]>

* Cleaned up and refined the after.md for approval

The after.md has been edited and cleaned. The file seems to be
easy to port to new docs for the concept exercises

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

* Created the instruction.md
A draft of instruction.md is made with a theme for review
Refactoring will be required later to compile everything to new folder structure

* Update languages/exercises/concept/conditionals/.docs/instructions.md

Co-authored-by: valentin-p <[email protected]>

* Second Iteration
- Removed Most of the Typos
- Made the formating more in line with standars used
- Grmmar and words changed

* added the functions definitions and the parameters

* Generated the scaffolding for test cases

* Test cases for first function added to conditionals_test.py
Minor corrections to instruction.py

* Added test cases for second function in conditional_test.py
- Minor logical corrections in instruction.py

* Added the final functions test cases

* [CI] Format code

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: David G <[email protected]>
Co-authored-by: Corey McCandless <[email protected]>
Co-authored-by: Erik Schierboom <[email protected]>
Co-authored-by: valentin-p <[email protected]>
ErikSchierboom added a commit to ErikSchierboom/python that referenced this issue Jan 29, 2021
* Created all required files for python concept - conditionals

* [CI] Format code

* CUsed prettier to format the files

* Used prettier to format the files

* First draft of introduction.md done

* Initial draft completed on introduction.md and working on after.md

* Made first draft of after.md

* Update languages/exercises/concept/conditionals/.docs/after.md

David cleaned up Grammar issues

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

minor grammar issues fixed from davids suggestion

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

grammar corrections ahh sigh!!

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Modifications to after.md as per review
-  The modifications made at "one line if statement"
- The inital draft had mentioned about one line if statement after the example for it
-  Now the one line if statement style guide is before showing example

* Minor corrections as stated in initial review
- Chnaged the eerenious output at line 34 for elif statement

* Created the initial draft for design.md

* Modified 'config.json'
- Misinterpreted "forked-from" now removed that and ammeded the mistake

* Update languages/exercises/concept/conditionals/.docs/introduction.md

Accepting Grammar corrections from Eric

Co-authored-by: Erik Schierboom <[email protected]>

* Cleaned up and refined the after.md for approval

The after.md has been edited and cleaned. The file seems to be
easy to port to new docs for the concept exercises

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

* Created the instruction.md
A draft of instruction.md is made with a theme for review
Refactoring will be required later to compile everything to new folder structure

* Update languages/exercises/concept/conditionals/.docs/instructions.md

Co-authored-by: valentin-p <[email protected]>

* Second Iteration
- Removed Most of the Typos
- Made the formating more in line with standars used
- Grmmar and words changed

* added the functions definitions and the parameters

* Generated the scaffolding for test cases

* Test cases for first function added to conditionals_test.py
Minor corrections to instruction.py

* Added test cases for second function in conditional_test.py
- Minor logical corrections in instruction.py

* Added the final functions test cases

* [CI] Format code

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: David G <[email protected]>
Co-authored-by: Corey McCandless <[email protected]>
Co-authored-by: Erik Schierboom <[email protected]>
Co-authored-by: valentin-p <[email protected]>
cmccandless added a commit that referenced this issue Jan 29, 2021
* Created all required files for python concept - conditionals

* [CI] Format code

* CUsed prettier to format the files

* Used prettier to format the files

* First draft of introduction.md done

* Initial draft completed on introduction.md and working on after.md

* Made first draft of after.md

* Update languages/exercises/concept/conditionals/.docs/after.md

David cleaned up Grammar issues

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

minor grammar issues fixed from davids suggestion

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

grammar corrections ahh sigh!!

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: David G <[email protected]>

* Modifications to after.md as per review
-  The modifications made at "one line if statement"
- The inital draft had mentioned about one line if statement after the example for it
-  Now the one line if statement style guide is before showing example

* Minor corrections as stated in initial review
- Chnaged the eerenious output at line 34 for elif statement

* Created the initial draft for design.md

* Modified 'config.json'
- Misinterpreted "forked-from" now removed that and ammeded the mistake

* Update languages/exercises/concept/conditionals/.docs/introduction.md

Accepting Grammar corrections from Eric

Co-authored-by: Erik Schierboom <[email protected]>

* Cleaned up and refined the after.md for approval

The after.md has been edited and cleaned. The file seems to be
easy to port to new docs for the concept exercises

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

Co-authored-by: Corey McCandless <[email protected]>

* Update languages/exercises/concept/conditionals/.docs/after.md

* Created the instruction.md
A draft of instruction.md is made with a theme for review
Refactoring will be required later to compile everything to new folder structure

* Update languages/exercises/concept/conditionals/.docs/instructions.md

Co-authored-by: valentin-p <[email protected]>

* Second Iteration
- Removed Most of the Typos
- Made the formating more in line with standars used
- Grmmar and words changed

* added the functions definitions and the parameters

* Generated the scaffolding for test cases

* Test cases for first function added to conditionals_test.py
Minor corrections to instruction.py

* Added test cases for second function in conditional_test.py
- Minor logical corrections in instruction.py

* Added the final functions test cases

* [CI] Format code

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: David G <[email protected]>
Co-authored-by: Corey McCandless <[email protected]>
Co-authored-by: Erik Schierboom <[email protected]>
Co-authored-by: valentin-p <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants