Remove track specific wording from triangle readme #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
And in fact any languages that do have skips are probably usingn that approach in all their exercises, which means it might best go somewhere global rather than per-exercise. As just one example see how Ruby put their So seems good to merge this! |
|
Thanks! 👍 |
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
binary: Add invalid edge case tests. Closes #275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a confused user of the Elm track because elm-test does not have a "skip" concept (exercism/elm#66). It seems to me that this sort of instruction would be more suitable as a comment in the test file for now.
The other option might be just qualify this note a bit.