Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading type in the Triangle for Elm exercise readme. #66

Closed
RiderSargent opened this issue Apr 15, 2016 · 2 comments
Closed

Misleading type in the Triangle for Elm exercise readme. #66

RiderSargent opened this issue Apr 15, 2016 · 2 comments

Comments

@RiderSargent
Copy link

In the Triangle exercise readme (http://exercism.io/exercises/elm/triangle/readme), it says

"Tests are provided, delete one `skip` at a time."

But there are no skipped tests. I'm happy to fix it, but I couldn't find the readme in this repo or the exercism.io repo. Can anyone point me in the right direction?

And thanks for all the work bringing Elm to Exercism! I'm loving the exercises.

@tgecho
Copy link
Contributor

tgecho commented Apr 16, 2016

Whoops, that is a bit confusing. Unfortunately, the exercise readme is shared between all of the language tracks (specifically here in the x-common repo: https://github.com/exercism/x-common/blob/master/triangle.md. In this case it may be a bit too specific, but I missed that part when I set up the tests. We can either submit a PR for the readme or figure out a way to add skips to these elm tests.

I'm not in a place to do either at the moment, so you're welcome to take a shot at it.

tgecho added a commit to tgecho/x-common that referenced this issue Jun 18, 2016
We had a confused user of the Elm track because elm-test does not have a "skip" concept (exercism/elm#66). It seems to me that this sort of instruction would be more suitable as a comment in the test file for now.
@tgecho
Copy link
Contributor

tgecho commented Jun 18, 2016

Upstream readme has been updated. Thanks!

@tgecho tgecho closed this as completed Jun 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants