rna-transcription: remove bad input tests #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about removing these tests completely. #902 Maybe that can be tomorrows PR.... |
Insti
approved these changes
Dec 5, 2017
|
The thought had crossed my mind too..... Should we flip a coin? |
|
Heads we remove them, Tails we delete them? |
|
Grabbing a coin... Call it in the air. |
|
Tails...... I guess they go. 👍 |
rpottsoh
changed the title
|
I agree with this, but maybe it's a good idea to leave PRs like this open for a little longer to give others a chance to weigh in.. |
|
thou hast forgotten to change the version number you probably should |
|
The comment in the json file is now out of date. |
|
Doh! thanks @petertseng |
petertseng
added a commit
to petertseng/exercism-ceylon
that referenced
this pull request
Jan 11, 2018
…ns 1.1.0 remove tests of invalid input exercism/problem-specifications#1027 exercism/problem-specifications#1028 Note for the future: This commit makes the decision to keep the invalid input. This decision is made arbitrarily, so there should be no hesitation about reversing in the future if that is appropriate. It's merely a desire to showcase Error. Even though that was already done in Hamming and will be done in largest-series-product.
petertseng
pushed a commit
to exercism/haskell
that referenced
this pull request
Jan 31, 2018
This reverts commit 07c7426. This reverts #634. In exercism/problem-specifications#1027 three error cases were removed by the result of a coin flip. Since that is insufficient reason to remove them from the Haskell track, the Haskell track chooses to keep them, and needs no further justification to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #977
Replacing expected value of
nullwith an error object.propose error object:
Let me know if the message should be re-worded.