Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rna-transcription: Add test case for invalid input #647

Merged
merged 4 commits into from
Jan 31, 2018

Conversation

MazeChaZer
Copy link
Contributor

@MazeChaZer MazeChaZer commented Jan 22, 2018

The return type of Maybe String already anticipates error handling, but I've seen many solutions on exercism.io that would just throw an exception on invalid input. This test should point people in the right direction.

@petertseng
Copy link
Member

In exercism/problem-specifications#1027 three error cases were removed by the result of a coin flip. Now it is left up to the decision of individual tracks whether to add them back. That is really unfortunate because I really don't care to make such a decision, but I'll resolve the problem by simply saying if someone will do the work I'll merge it.

If the Haskell track is wanting to test invalid invalid inputs, I would suggest using those exact three case that were removed in exercism/problem-specifications#1027 and the justification for keeping them can just be that the justification for removing them was not strong enough.

@MazeChaZer
Copy link
Contributor Author

I updated the file with the prior examples from the specification.

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be great, thank you.

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed that this file is now the same as it was BEFORE 07c7426 (#634)

@petertseng
Copy link
Member

petertseng commented Jan 31, 2018

I'm going to use something like this

rna-transcription 1.2.0.7: Revert "rna 1.1.0.5: remove Nothing tests"

This reverts commit 07c7426.

In exercism/problem-specifications#1027 three
error cases were removed by the result of a coin flip. Since that is
insufficient reason to remove them from the Haskell track, the Haskell
track chooses to keep them, and needs no further justification to do so.

@petertseng petertseng merged commit b4e8587 into exercism:master Jan 31, 2018
@MazeChaZer MazeChaZer deleted the patch-1 branch January 31, 2018 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants