Cleanup skipping

[Mezzle]

PHPUnit has in built test skipping, this should be used over @group skip,
as this means that testing commands can be ran from any working directory
rather than from the base php directory. Unsure as to whether exercism will
actually currently provide the phpunit.xml - but this means there's now no
longer a need to serve files to the root either

[Mezzle]

Having looked into this further, I've realised the reason for this - so that the tests can all be ran against the examples in the Makefile.

I've added a solution for this - but it feels "hacky".

Personally, I prefer the benefits of using markTestSkipped() as it allows the test files to be ran "correctly" from anywhere... but that's me.

If you're not happy with this change - it'll take but a moment to correct my other submissions to match the old style @group skipped :)

[kytrinyx]

Thanks for weighing in on this. I'm not actually convinced that we need to have them skipped at all (which sure would make the tests easier on CI).

There's been a fairly meaty discussion about the pros and cons: exercism/exercism#856

@wilmoore What do you think?

[Mezzle]

I'm of the opinion that tests should only be skipped if they can't run on a specific system. If they're just failing, they either shouldn't be there, or they should fail.

Adding the skips seems like it's potentially teaching the wrong lesson regarding as to when "skipping tests" should be used?

[wilmoore]

There's been a fairly meaty discussion about the pros and cons: exercism/exercism#856
@wilmoore What do you think?

I would personally prefer no skips; however, I realize that there are benefits to having the skips for a certain level of developer. That being said, I suspect there may be other ways to solve that problem, so perhaps we can do away with the skips and address the other issues separately.

[kytrinyx]

Yeah, the skips are helpful for people who are quite new to programming (though not at all helpful for people who are completely new to programming... that's a different problem).

I'm now leaning towards getting rid of the skips altogether, except maybe in Ruby, JavaScript, and perhaps Python (where we get a lot more beginners).

[wilmoore]

except maybe in Ruby, JavaScript, and perhaps Python

Or...perhaps we just provide better on-boarding across the board?

[kytrinyx]

Or...perhaps we just provide better on-boarding across the board?

Working on it.

[wilmoore]

So, I think this PR would work if all of the skips got dropped.

[Mezzle]

Will do so tomorrow when I'm at a PC with dev tools on it

[kytrinyx]

@Mezzle I'm seeing new commits. Is this done? The test suite doesn't look happy, but I haven't looked into what's causing that in case you're still working on it.

[Mezzle]

I pushed new commits, but didn't wait to check on travis!

I've re-added one skip - where the test code provides an example of the test (testing the gigasecond for your own birthday)

Assuming this passes, it should now be complete.

[kytrinyx]

This looks good. Thank you!