bob: enable all tests

[michel-slm]

Enable the tests currently disabled in bob_tests -- without them an incomplete implementation of bob would pass.

[kytrinyx]

Was there a particular reason why you enabled all of the tests?

[michel-slm]

@kytrinyx not enabling them means the specification is not being exercised fully. Unless the disabled tests are intentional to allow people to develop their solution incrementally and enable the tests as they tackle each part?

In the other exercises normally the entire tests are enabled out of the box - tests would fail at the beginning but it does not matter, right?

[kytrinyx]

Yes, the purpose is to allow people to develop their solution incrementally.

In the other exercises normally the entire tests are enabled out of the box

In the other problems in Elixir?

In some languages this is done for all the problems, in others for none of them. In a few languages it's done for the first problem or first few.

There has already been some discussion of this here and here.

As you'll see from the discussions I'm quite open to removing skips, but I want to have a specific reason to do so in the language we're discussing. I suspect that it's the right thing to do for elixir -- rarely will a beginner start with elixir, so my guess is that the hand-holding is less than helpful.

For elixir, it looks like we are skipping tests in the following test files:

anagram/anagram_test.exs
bob/bob_test.exs
gigasecond/gigasecond_test.exs
grade-school/grade_school_test.exs
leap/leap_test.exs
phone-number/phone_number_test.exs
point-mutations/point_mutations_test.exs
rna-transcription/rna_transcription_test.exs

If we remove skips in Bob we should remove skips in the other one as well.

[michel-slm]

Good point; that's a good idea. I'll focus on updating the documentation then? I like the way xcpp/bob documents the use of an ifdef marker that disable tests below it, and that the user should move this marker as they progress through the test suite.

[kytrinyx]

Yes, either updating the documentation, or deleting all the skips throughout. The ifdef marker is an interesting approach.