Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'math' topic to relevant exercises in track config #268

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Add 'math' topic to relevant exercises in track config #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"unlocked_by": null,
"difficulty": 2,
"topics": [
"mathematics"
"math"
]
},
{
Expand Down Expand Up @@ -121,7 +121,6 @@
"unlocked_by": null,
"difficulty": 3,
"topics": [
"arithmetic",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit unsure whether we remove arithmetic here. I think that it's not really mathy, but I'll admit that there's arithmetic involved. I'm tempted to leave it off per the discussion in exercism/exercism#4110

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses floating point arithmetic, which is a bit special in OCaml (you need to use floating point specific operators as there's no overloading). So floating_point might be worth adding to this list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree! I'll update this one to say 'floating_point'. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevejb71 It already has floats. Should we go with floats or floating_point?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the topics.txt file has floating_point_numbers, so I think we should go with that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to be aware of is that in the UI long names get truncated. I'd lean towards floats (and would suggest updating topics.txt, too).

Copy link
Contributor

@stevejb71 stevejb71 Aug 9, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to add a rule to check lengths in the config linter.

I'm ok with floats.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, cool, thanks!

"floats"
]
},
Expand All @@ -131,9 +130,7 @@
"core": false,
"unlocked_by": null,
"difficulty": 3,
"topics": [
"mathematics"
]
"topics": []
},
{
"slug": "pangram",
Expand Down Expand Up @@ -162,7 +159,7 @@
"unlocked_by": null,
"difficulty": 4,
"topics": [
"mathematics"
"math"
]
},
{
Expand All @@ -181,9 +178,7 @@
"core": false,
"unlocked_by": null,
"difficulty": 4,
"topics": [
"arithmetic"
]
"topics": []
},
{
"slug": "binary-search",
Expand Down Expand Up @@ -257,7 +252,7 @@
"difficulty": 5,
"topics": [
"algorithms",
"mathematics"
"math"
]
},
{
Expand All @@ -277,7 +272,7 @@
"unlocked_by": null,
"difficulty": 6,
"topics": [
"arithmetic"
"math"
]
},
{
Expand Down