-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'math' topic to relevant exercises in track config #268
Conversation
The new site lets people filter optional exercises by topic, and this makes it easy for people to skip past them. This is important since the math-y exercises are not key to learning the language, and a lot of people find them intimidating and demotivating. This updates any 'mathematics' topics to be 'math' since it's shorter and won't get cropped in the UI. It also removes the math topics for any exercises that are not in the canonical math-y list.
9c4759b
to
84e41a9
Compare
@@ -121,7 +121,6 @@ | |||
"unlocked_by": null, | |||
"difficulty": 3, | |||
"topics": [ | |||
"arithmetic", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit unsure whether we remove arithmetic here. I think that it's not really mathy, but I'll admit that there's arithmetic involved. I'm tempted to leave it off per the discussion in exercism/exercism#4110
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It uses floating point arithmetic, which is a bit special in OCaml (you need to use floating point specific operators as there's no overloading). So floating_point might be worth adding to this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree! I'll update this one to say 'floating_point'. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevejb71 It already has floats
. Should we go with floats
or floating_point
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the topics.txt file has floating_point_numbers, so I think we should go with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to be aware of is that in the UI long names get truncated. I'd lean towards floats
(and would suggest updating topics.txt
, too).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to add a rule to check lengths in the config linter.
I'm ok with floats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, cool, thanks!
The new site lets people filter optional exercises by topic, and this
makes it easy for people to skip past them.
This is important since the math-y exercises are not key to learning
the language, and a lot of people find them intimidating and demotivating.
This updates any 'mathematics' topics to be 'math' since it's shorter
and won't get cropped in the UI.
It also removes the math topics for any exercises that are not in the
canonical math-y list.
exercism/exercism#4110