Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetch configlet script #49

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Add fetch configlet script #49

merged 2 commits into from
Jun 8, 2021

Conversation

ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented May 5, 2021

This PR does two things:

  • Add fetch configlet script
  • Add codeowner for fetch-configlet script

The ./bin/fetch-configlet script helps maintainers run configlet locally, as is used by all tracks. This makes running commands like configlet lint, an essential part of maintaining a track, very easy.

Ref exercism/configlet#286

@ErikSchierboom ErikSchierboom requested a review from a team as a code owner May 5, 2021 13:06
Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes just to sync with the latest upstream copy. I don't mind if we just do it later in a mass PR, though.

Comment on lines 5 to 6
# Please submit bugfixes/improvements to the above file to ensure that all tracks
# benefit from the changes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Please submit bugfixes/improvements to the above file to ensure that all tracks
# benefit from the changes.
# Please submit bugfixes/improvements to the above file to ensure that all tracks benefit from the changes.

cut -d'"' -f4
}

main () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
main () {
main() {

main () {
if [[ -d ./bin ]]; then
output_dir="./bin"
elif [[ $PWD = */bin ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elif [[ $PWD = */bin ]]; then
elif [[ $PWD == */bin ]]; then

@iHiD iHiD merged commit 118428d into main Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants