Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch-configlet: add to CODEOWNERS in every track repo #286

Closed
ee7 opened this issue Apr 28, 2021 · 4 comments
Closed

fetch-configlet: add to CODEOWNERS in every track repo #286

ee7 opened this issue Apr 28, 2021 · 4 comments
Labels
kind: feature User-facing enhancement

Comments

@ee7
Copy link
Member

ee7 commented Apr 28, 2021

This file probably shouldn't be changed on a per-track level, so adding it to CODEOWNERS would help us notice if somebody tries to do that.

We could make something like the below change to the typical .github/CODEOWNERS file

 # Maintainers 
 config/maintainers.json @exercism/maintainers-admin

 # Code owners
 .github/CODEOWNERS      @exercism/maintainers-admin

+# Changes to `fetch-configlet` should be made in the `exercism/configlet` repo
+bin/fetch-configlet     @exercism/maintainers-admin
This was referenced May 4, 2021
@ee7
Copy link
Member Author

ee7 commented May 5, 2021

Tracks where a PR wasn't created:

  • bash (script is named bin/fetch_configlet, with an underscore)
  • elixir (script is named bin/fetch_configlet.sh, with underscore and extension)
  • j (missing fetch script entirely)
  • julia (missing fetch script entirely)
  • php (missing fetch script entirely)
  • research_experiment_1 (I guess you excluded deliberately)
  • scheme (script located at scripts/fetch-configlet)

@ErikSchierboom
Copy link
Member

@ee7 PRs have been created for all those repos, except the research_experiment_1 You can omit that repo from any cross-track scripts you run, as it is not actually a track repo.

ee7 pushed a commit to exercism/nim that referenced this issue May 6, 2021
Each track repo has a `fetch-configlet` script that is a copy of the one
in the `configlet` repo.

We are therefore adding the path of the track copy to `CODEOWNERS` to
prevent the track from changing it independently. A contributor should
propose changes against the upstream copy so that any update can benefit
every track.

See:
- https://github.com/exercism/configlet/blob/main/scripts/fetch-configlet
- exercism/configlet#286
@ee7 ee7 changed the title fetch-configlet: consider adding to CODEOWNERS in every track repo fetch-configlet: add to CODEOWNERS in every track repo May 9, 2021
@ee7
Copy link
Member Author

ee7 commented Jun 15, 2021

Looks like we're done now. Closing.

$ rg --sort path --hidden --glob 'CODEOWNERS' --files-with-matches --ignore-case 'bin/fetch.+configlet' | wc -l
79

https://github.com/search?q=topic%3Aexercism-track+org%3Aexercism&type=Repositories

79 repository results

@ee7 ee7 closed this as completed Jun 15, 2021
@ErikSchierboom
Copy link
Member

🥳

@ee7 ee7 added the kind: feature User-facing enhancement label May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature User-facing enhancement
Projects
None yet
Development

No branches or pull requests

2 participants