-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding isogram #595
Merged
Merged
adding isogram #595
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
857bc67
adding isogram
ac9dd46
fix to isogram example
ebcd98e
isogram:some corrections
1628957
Update config.json
d1556ea
Test.hs correction
17c7c2f
Update Isogram.hs
47de491
isogram, algorithm changed
abf6d1e
isogram: regenerate readme
petertseng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
# Isogram | ||
|
||
Determine if a word or phrase is an isogram. | ||
|
||
An isogram (also known as a "nonpattern word") is a word or phrase without a repeating letter. | ||
|
||
Examples of isograms: | ||
|
||
- lumberjacks | ||
- background | ||
- downstream | ||
|
||
The word *isograms*, however, is not an isogram, because the s repeats. | ||
|
||
|
||
## Getting Started | ||
|
||
For installation and learning resources, refer to the | ||
[exercism help page](http://exercism.io/languages/haskell). | ||
|
||
## Running the tests | ||
|
||
To run the test suite, execute the following command: | ||
|
||
```bash | ||
stack test | ||
``` | ||
|
||
#### If you get an error message like this... | ||
|
||
``` | ||
No .cabal file found in directory | ||
``` | ||
|
||
You are probably running an old stack version and need | ||
to upgrade it. | ||
|
||
#### Otherwise, if you get an error message like this... | ||
|
||
``` | ||
No compiler found, expected minor version match with... | ||
Try running "stack setup" to install the correct GHC... | ||
``` | ||
|
||
Just do as it says and it will download and install | ||
the correct compiler version: | ||
|
||
```bash | ||
stack setup | ||
``` | ||
|
||
## Running *GHCi* | ||
|
||
If you want to play with your solution in GHCi, just run the command: | ||
|
||
```bash | ||
stack ghci | ||
``` | ||
|
||
## Feedback, Issues, Pull Requests | ||
|
||
The [exercism/haskell](https://github.com/exercism/haskell) repository on | ||
GitHub is the home for all of the Haskell exercises. | ||
|
||
If you have feedback about an exercise, or want to help implementing a new | ||
one, head over there and create an issue. We'll do our best to help you! | ||
|
||
## Source | ||
|
||
Wikipedia [https://en.wikipedia.org/wiki/Isogram](https://en.wikipedia.org/wiki/Isogram) | ||
|
||
## Submitting Incomplete Solutions | ||
It's possible to submit an incomplete solution so you can see how others have completed the exercise. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
name: isogram | ||
|
||
dependencies: | ||
- base | ||
|
||
library: | ||
exposed-modules: Isogram | ||
source-dirs: src | ||
|
||
tests: | ||
test: | ||
main: Tests.hs | ||
source-dirs: test | ||
dependencies: | ||
- isogram | ||
- hspec |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
module Isogram (isIsogram) where | ||
|
||
import Data.Char (toLower, isLetter) | ||
import Data.List (sort, group) | ||
|
||
isIsogram :: String -> Bool | ||
isIsogram = all ((1==) . length) . group . sort . filter isLetter . map toLower |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
name: isogram | ||
version: 1.1.0.1 | ||
|
||
dependencies: | ||
- base | ||
|
||
library: | ||
exposed-modules: Isogram | ||
source-dirs: src | ||
dependencies: | ||
# - foo # List here the packages you | ||
# - bar # want to use in your solution. | ||
|
||
tests: | ||
test: | ||
main: Tests.hs | ||
source-dirs: test | ||
dependencies: | ||
- isogram | ||
- hspec |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
module Isogram (isIsogram) where | ||
|
||
isIsogram :: String -> Bool | ||
isIsogram = error "You need to implement this function!" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
resolver: lts-8.21 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
{-# LANGUAGE RecordWildCards #-} | ||
|
||
import Data.Foldable (for_) | ||
import Test.Hspec (Spec, describe, it, shouldBe) | ||
import Test.Hspec.Runner (configFastFail, defaultConfig, hspecWith) | ||
|
||
import Isogram (isIsogram) | ||
|
||
main :: IO () | ||
main = hspecWith defaultConfig {configFastFail = True} specs | ||
|
||
specs :: Spec | ||
specs = describe "isIsogram" $ for_ cases test | ||
where | ||
|
||
test Case{..} = it description assertion | ||
where | ||
assertion = isIsogram input `shouldBe` expected | ||
|
||
|
||
data Case = Case { description :: String | ||
, input :: String | ||
, expected :: Bool | ||
} | ||
|
||
cases :: [Case] | ||
cases = [ Case { description = "empty string" | ||
, input = "" | ||
, expected = True | ||
} | ||
, Case { description = "isogram with only lower case characters" | ||
, input = "isogram" | ||
, expected = True | ||
} | ||
, Case { description = "word with one duplicated character" | ||
, input = "eleven" | ||
, expected = False | ||
} | ||
, Case { description = "longest reported english isogram" | ||
, input = "subdermatoglyphic" | ||
, expected = True | ||
} | ||
, Case { description = "word with duplicated character in mixed case" | ||
, input = "Alphabet" | ||
, expected = False | ||
} | ||
, Case { description = "hypothetical isogrammic word with hyphen" | ||
, input = "thumbscrew-japingly" | ||
, expected = True | ||
} | ||
, Case { description = "isogram with duplicated non letter character" | ||
, input = "Hjelmqvist-Gryb-Zock-Pfund-Wax" | ||
, expected = True | ||
} | ||
, Case { description = "made-up name that is an isogram" | ||
, input = "Emily Jung Schwartzkopf" | ||
, expected = True | ||
} | ||
, Case { description = "duplicated character in the middle" | ||
, input = "accentor" | ||
, expected = False | ||
} | ||
] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove one newline here so there is only one between
module
andisIsogram
, not two.