adding isogram

[Average-user]

Another Unimplemented exercise

[Average-user]

This one is ok. right?

[petertseng]

in contrast to Maybe, I don't think this:

1. affects where we would choose to place the exercise
2. is necessarily going to be in everyone's solutions

so I would remove it

[Average-user]

right

[petertseng]

1.1.0.1

[petertseng]

given that #144 tells us this line helps for exercises with numbers but this is not one, I think it can be removed?

[petertseng]

since

1. Not every solution wants or needs this
2. I wouldn't want to encourage the habit of importing everything rather than the specific list of functions desired

I would remove this line

[petertseng]

OK, I don't think there's anything big to change, so it will be merged no more than 48 hours. There are two small things. I was going to do them myself. You can if you want.

[petertseng]

as you can see in https://github.com/Average-user/haskell/blob/d1556eadc748688089e3261700ab9678f2caf245/exercises/isogram/README.md, the quotes mean it is not a link.

I'm going to regenerate this README anyway so it doesn't matter whether you fix this, but don't put quotes in the brackets

[Average-user]

ok, so the next time i make PR like this, do i even have to put the README.md?

[petertseng]

I guess not! I will just do it. However, it would be good if you just put a README.md that just says "please regenerate this for me" so that I don't forget to!

[Average-user]

ok, also, dont merge yet, i want to implement something

[petertseng]

I would remove one newline here so there is only one between module and isIsogram, not two.

[Average-user]

Now you can merge if you want

[Average-user]

How can i do if i want to do another PR before this one gets merge?

[petertseng]

How can i do if i want to do another PR before this one gets merge?

Make a branch.

[Average-user]

But Github will still catch the differences with the (in this case) Isogram commits

[petertseng]

But Github will still catch the differences with the (in this case) Isogram commits

Github shows all commits that are not on the target branch (Exercism's master branch) but are on the PR branch (your new branch). The Isogram commits should not be on your new branch. Achieve that using whatever means you prefer. Ask if you want a suggestion of a preferred means.

[Average-user]

Thanks, i'll take that suggestion you offer .

[petertseng]

Case 1: You do not already have a branch.

You decide on a branch name, and then you git checkout -b your_new_branch_name 7dc8cf2f0403857a79d13c4916d4b26f99af15e4

(why, because 7dc8cf2f0403857a79d13c4916d4b26f99af15e4 is the latest commit shown on https://github.com/exercism/haskell/commits/master )

Case 2: You already have a branch.

You git checkout your_existing_branch_name if you are not already on that branch, then you git rebase -i 7dc8cf2f0403857a79d13c4916d4b26f99af15e4, then you delete all lines that are related to Isogram.

[Average-user]

Instead of this key (or whatever) 7dc8cf2f0403857a79d13c4916d4b26f99af15e4 can I use the link https://github.com/exercism/haskell?

[petertseng]

Instead of this key (or whatever) 7dc8cf2f0403857a79d13c4916d4b26f99af15e4 can I use the link https://github.com/exercism/haskell?

If the repository https://github.com/exercism/haskell is a remote on your local copy of the git repo, you may instead use your_name_for_the_exercism_remote/master instead of 7dc8cf2f0403857a79d13c4916d4b26f99af15e4.

[petertseng]

far as I can tell, we are ready to go.

[petertseng]

Thank you for implementing this exercise!