Support .NET Core #348
Merged
Support .NET Core #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robkeim The PR has been updated and I think it is now correctly working. Could you perhaps review the PR again? If you deem it correct, feel free to merge. |
robkeim
approved these changes
Sep 2, 2017
docs/TESTS.md
Outdated
|
|
||
| Install [NUnit](http://nunit.org/index.php?p=download) via NuGet package manager with the NUnit.Console package. This will add the reference to the project. | ||
| Solving an exercise means making all its tests pass. By default, only one test (the first one) is executed when you run the tests. This is intentional, as it allows you to focus on just making that one test pass. Once it passes, you can enable the next test by removing `Skip = "Remove to run test"` from the test's `[<Fact>]` or `[<Theory?]` attribute. When all tests have been enabled and your implementation makes them all pass, you'll have solved the exercise! |
exercises/acronym/AcronymTest.fs
Outdated
| open Acronym | ||
|
|
||
| [<Test>] | ||
| let ``Empty string abbreviated to empty string`` () = | ||
| Assert.That(acronym "", Is.EqualTo("")) | ||
| acronym "" |> should equal "" |
There was a problem hiding this comment.
@ErikSchierboom did you decide not to update this to EmptyString for some reason?
Update small typo
|
@robkeim I forgot about the EmptyString. Perhaps I can fix it later in a new commit? |
|
@ErikSchierboom yes I figured you could do it in another PR. Once the fix of my typo is green I'll go ahead and merge this branch. |
|
Thanks for your hard work on this @ErikSchierboom! Great job 🎉 🎉 🎉 |
|
Hurray! |
This was referenced Sep 3, 2017
Closed
|
@ErikSchierboom Fantastic. Thanks so much for taking the time to do this overhaul... this is huge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues:
What is left to do is:
[<TestCase>]tests with individual tests. (Replace [<TestCase>] tests with individual tests #298)Note: it is still a work-in-progress, but if you'd be willing to take a look, that would be great!
CC: @jpreese Would you also mind taking a look?
This fixes #203, #229, #251, #277, #297, #308, #309