-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace [<TestCase>] tests with individual tests #298
Comments
This is also being discussed in the C# track exercism/csharp#194 |
Here are the list of exercises using the |
Great work gathering this data @robkeim! |
I can start working on these. I will always leave a comment here before starting to convert the tests for an exercise - this way you'll know which ones are still up for grabs :) |
Sounds great, thanks @balazsbotond. |
That would be brilliant @balazsbotond! |
Done:
|
#300) * Fix #286 - Linked List: change pop and shift to return option * Linked List: Add missing Ignore attribute * Markdown: Use correct tags for italic and bold text * Revert "Fix #286 - Linked List: change pop and shift to return option" This reverts commit 9da0115. * atbash-cipher: Replace [<TestCase>] tests with individual tests (#298) * Add missing [<Test>] attribute * Add missing [<Ignore>] attributes
* Fix #286 - Linked List: change pop and shift to return option * Linked List: Add missing Ignore attribute * Markdown: Use correct tags for italic and bold text * Revert "Fix #286 - Linked List: change pop and shift to return option" This reverts commit 9da0115. * Acronym: Replace [<TestCase>] tests with individual tests (#298) * acronym: Add missing [<TestCase>] attribute * Add missing [<Ignore>] attributes
* Fix #286 - Linked List: change pop and shift to return option * Linked List: Add missing Ignore attribute * Markdown: Use correct tags for italic and bold text * Revert "Fix #286 - Linked List: change pop and shift to return option" This reverts commit 9da0115. * clock: Replace [<TestCase>] tests with individual tests (#298)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@ErikSchierboom I'm closing this issue as this should now be obsolete with the move to using test generators. |
@robkeim Good point. |
We have several places where we use
[TestCase]
to create a single test with multiple input values. While efficient (no code duplication), this is not the best of user experiences as it makes it harder to run a single test and also doesn't really allow us to mark the various input values with a descriptive text. It also doesn't align with how canonical data for exercises is defined, which only works on single test cases.Consider the
isogram
exercises's tests:What's the difference between test case one and two? It's not immediately obvious. The canonical-data of this exercise looks much nicer. I think we should convert the [] tests to individual tests.
The text was updated successfully, but these errors were encountered: