Add Exercise: Protein Translation #245
Conversation
This is needed for e.g. the Protein-Translation exercise feautred in 48in24.
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
LGTM. I'll let some from the @exercism/fortran maintainers team look at the Fortran-specific side of things. |
|
@D3usXMachina If no one has reviewed in a couple of days, please ping me. |
| If it works for one codon, the program should work for all of them. | ||
| However, feel free to expand the list in the test suite to include them all. | ||
|
|
||
| There are also three terminating codons (also known as 'STOP' codons); if any of these codons are encountered (by the ribosome), all translation ends and the protein is terminated. |
There was a problem hiding this comment.
| There are also three terminating codons (also known as 'STOP' codons); if any of these codons are encountered (by the ribosome), all translation ends and the protein is terminated. | |
| There are also three terminating codons (also known as 'STOP' codons); | |
| if any of these codons are encountered (by the ribosome), all translation ends and the protein is terminated. |
One line per sentence, though this can be one line per phrase, since this is a reasonable break, and only one portion of these might be changed or updated in the future, leaving a clean diff at that point.
Definitely an optional change.
There was a problem hiding this comment.
@kotp You do know that these instructions.md file's contents are synced from problem-specifications, right? So any suggestions to change them would have to be done there.
| @@ -221,6 +222,38 @@ subroutine assert_equal_str(estr,istr,test_description) | |||
| endif | |||
| end subroutine | |||
|
|
|||
| !------------------------------------------------------------------ | |||
There was a problem hiding this comment.
I'm not sure changes to the TesterMain.f90 within an exercise's directory will work in the test runner. @pclausen ?
There was a problem hiding this comment.
This file isn't in the exercise's directory.
Sorry for bundling the two things together.
I originally opened a separate pull request for the change to the testlib #242, but since that commit is in this pull request as well, I thought it might be unnecessary to recreate the other PR.
There was a problem hiding this comment.
No it's needed due to the fact that the TesterMain.f90 is downloaded into the test runner I believe. @pclausen ?
|
The test runner has been updated! |
Adds the protein translation exercise (discussed here).
Also adds the required
assert_equalfor arrays of strings to the testlib (discussed here).