Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add practice and prerequisites - 1 #1500

Merged
merged 6 commits into from
Feb 12, 2021
Merged

add practice and prerequisites - 1 #1500

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
760aed0
add practice and prerequisites - start
mikedamay Feb 11, 2021
c439207
add practice and prerequisites - two-fer
mikedamay Feb 11, 2021
46a9676
add practice and prerequisites - leap
mikedamay Feb 12, 2021
890a047
Apply suggestions from code review
mikedamay Feb 12, 2021
2c553ed
add practice and prerequisites - leap
mikedamay Feb 12, 2021
73571be
Merge remote-tracking branch 'origin/add-practice-n-prereq' into add-…
mikedamay Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions concepts/enumerables/about.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
TODO: complete document
1 change: 1 addition & 0 deletions concepts/enumerables/introduction.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
TODO: complete document
1 change: 1 addition & 0 deletions concepts/enumerables/links.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[]
1 change: 1 addition & 0 deletions concepts/lambdas/about.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
TODO: complete document
1 change: 1 addition & 0 deletions concepts/lambdas/introduction.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
TODO: complete document
1 change: 1 addition & 0 deletions concepts/lambdas/links.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[]
1 change: 1 addition & 0 deletions concepts/math-operators/about.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
TODO: complete document
1 change: 1 addition & 0 deletions concepts/math-operators/introduction.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
TODO: complete document
1 change: 1 addition & 0 deletions concepts/math-operators/links.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[]
12 changes: 6 additions & 6 deletions config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,8 +641,8 @@
"slug": "two-fer",
"name": "Two Fer",
"uuid": "57f02d0e-7b75-473b-892d-26a7d980c4ce",
"practices": [],
"prerequisites": [],
"practices": ["optional-parameters", "interpolation"],
"prerequisites": ["optional-parameters", "interpolation"],
"difficulty": 1,
"topics": [
"optional_values",
Expand All @@ -653,8 +653,8 @@
"slug": "leap",
"name": "Leap",
"uuid": "8ba15933-29a2-49b1-a9ce-70474bad3007",
"practices": [],
"prerequisites": [],
"practices": ["math-operators", "if-statements"],
"prerequisites": ["math-operators", "if-statements"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't yet have a Concept Exercise that unlocks math-operators . This means that for the website, this prerequisite will be completely ignored. I was wondering if it would make sense to guard against these types of situations by being explicit and also adding numbers as the prerequisite. What do you think?

Copy link
Contributor Author

@mikedamay mikedamay Feb 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the mandate was to create concepts for practice exercises even where there was no concept exercise illustrating the concept. Did I misunderstand?

Issue #1499 addresses the question of concepts without illustrative exercises. So far we need concepts for lambdas, enumerables, math-operators, extension-methods and yield - after looking at 3 exercises!

Issue #1459 (mismatch between exercises.json and config.json) also relates to this. I think it will indeed cause math-operators to be folded into numbers. I hesitated to do it in this PR as the links in the numbers's about.md do not include % so text will need to be altered as part of issue #1459.

This is what I mean about keeping things straight.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the mandate was to create concepts for practice exercises even where there was no concept exercise illustrating the concept. Did I misunderstand?

No you understood correctly. This is all just trial and error. I'm just thinking of the effect it would have one students for the time being while we don't have a math-operators exercise. That is why I suggested adding the numbers prerequisite, althought that would be a slightly duplicate prerequisite once we have math-operators.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enuf. numbers in addition. n.p.

"difficulty": 1,
"topics": [
"conditionals",
Expand Down Expand Up @@ -1059,8 +1059,8 @@
"slug": "accumulate",
"name": "Accumulate",
"uuid": "3c0563dc-665a-45b4-9b29-f133e235efd0",
"practices": [],
"prerequisites": [],
"practices": ["lambdas", "foreach"],
"prerequisites": ["lambdas", "generic-types", "foreach", "enumerables"],
"difficulty": 2,
"topics": [
"extension_methods",
Expand Down