add practice and prerequisites - 1 #1500
Conversation
|
Thanks for working on this! I'll do a proper review once you're done. |
|
Please review this as is. I'm not going to do all 120 in a single PR. It will lock up the config.json / create merge conflicts. I'm also documenting the concepts in separate PRs. It's a question of keeping things straight. I'm even finding anomalies with the concept exercises that I had not expected. I will keep PRs as draft until a review is appropriate. |
config.json
Outdated
| "practices": [], | ||
| "prerequisites": [], | ||
| "practices": ["math-operators", "if-statements"], | ||
| "prerequisites": ["math-operators", "if-statements"], |
There was a problem hiding this comment.
We don't yet have a Concept Exercise that unlocks math-operators . This means that for the website, this prerequisite will be completely ignored. I was wondering if it would make sense to guard against these types of situations by being explicit and also adding numbers as the prerequisite. What do you think?
There was a problem hiding this comment.
I thought the mandate was to create concepts for practice exercises even where there was no concept exercise illustrating the concept. Did I misunderstand?
Issue #1499 addresses the question of concepts without illustrative exercises. So far we need concepts for lambdas, enumerables, math-operators, extension-methods and yield - after looking at 3 exercises!
Issue #1459 (mismatch between exercises.json and config.json) also relates to this. I think it will indeed cause math-operators to be folded into numbers. I hesitated to do it in this PR as the links in the numbers's about.md do not include % so text will need to be altered as part of issue #1459.
This is what I mean about keeping things straight.
There was a problem hiding this comment.
I thought the mandate was to create concepts for practice exercises even where there was no concept exercise illustrating the concept. Did I misunderstand?
No you understood correctly. This is all just trial and error. I'm just thinking of the effect it would have one students for the time being while we don't have a math-operators exercise. That is why I suggested adding the numbers prerequisite, althought that would be a slightly duplicate prerequisite once we have math-operators.
There was a problem hiding this comment.
Fair enuf. numbers in addition. n.p.
Co-authored-by: Erik Schierboom <[email protected]>
…practice-n-prereq
I'll update a few practice exercises in config.json merge that and then add document the missing concepts separately.