Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: Add reimplements property to tests.toml file #316

Closed
ErikSchierboom opened this issue May 7, 2021 · 0 comments · Fixed by #317
Closed

sync: Add reimplements property to tests.toml file #316

ErikSchierboom opened this issue May 7, 2021 · 0 comments · Fixed by #317
Labels
cmd: sync kind: feature User-facing enhancement

Comments

@ErikSchierboom
Copy link
Member

Having a reimplements property added to the tests.toml file helps identify re-implemented test cases:

[b9228bb1-465f-4141-b40f-1f99812de5a8]
description = "disallow first strand longer"
reimplements = "919f8ef0-b767-4d1b-8516-6379d07fcb28"
@ErikSchierboom ErikSchierboom mentioned this issue May 7, 2021
Merged
@ee7 ee7 changed the title Add reimplements property to tests.toml file sync: Add reimplements property to tests.toml file May 9, 2021
@ee7 ee7 added cmd: sync kind: feature User-facing enhancement labels May 10, 2021
@ee7 ee7 closed this as completed in #317 May 31, 2021
ee7 added a commit that referenced this issue May 31, 2021
@ErikSchierboom @ee7
sync: write tests.toml with reimplements (#317)
b087357 
With this commit, `configlet sync` adds a `reimplements` key/value pair
to each relevant test case when writing the `tests.toml` file. This is
purely to help the reader to identify reimplemented test cases.

An example test case for the `hamming` exercise:

```toml
[b9228bb1-465f-4141-b40f-1f99812de5a8]
description = "disallow first strand longer"
reimplements = "919f8ef0-b767-4d1b-8516-6379d07fcb28"
```

This commit also tries to improve the comment at the start of the
`tests.toml` file.

Closes: #316

Co-authored-by: ee7 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmd: sync kind: feature User-facing enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sync: write tests.toml with reimplements exercism/configlet
2 participants
@ErikSchierboom @ee7