Warn when the storage layout base is near the end of storage (2^64 slots or less) #15912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusaaguiar
changed the base branch from
develop
to
storageLocationStorageLayout
matheusaaguiar
force-pushed
the
storageLocationStorageLayout
branch
from
a13d53e to
f27af62
Compare
matheusaaguiar
force-pushed
the
warnStorageLayoutNearTheEnd
branch
3 times, most recently
from
9d77c0f to
acb5733
Compare
cameel
requested changes
Mar 4, 2025
matheusaaguiar
force-pushed
the
storageLocationStorageLayout
branch
4 times, most recently
from
0c0c671 to
1423298
Compare
cameel
added
the
has dependencies
matheusaaguiar
force-pushed
the
warnStorageLayoutNearTheEnd
branch
from
acb5733 to
fa803f5
Compare
cameel
reviewed
Mar 10, 2025
cameel
force-pushed
the
warnStorageLayoutNearTheEnd
branch
from
1cd145c to
85431e6
Compare
cameel
previously approved these changes
Mar 10, 2025
There was a problem hiding this comment.
The main problem is that the warning still only gets issued for contracts with a layout specifier. Other than that just a few minor things.
But I just pushed fixups that address all of this so I'm approving the PR. If you accept the fixups, you can simply squash them into the right commits and merge.
cameel
removed
the
has dependencies
cameel
reviewed
Mar 10, 2025
cameel
force-pushed
the
warnStorageLayoutNearTheEnd
branch
from
85431e6 to
b0104f3
Compare
matheusaaguiar
force-pushed
the
warnStorageLayoutNearTheEnd
branch
from
b0104f3 to
5297950
Compare
cameel
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #15727.