Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust storage layout to consider explicit storage base location #15668

Merged
merged 4 commits into from
Mar 8, 2025
Merged

Adjust storage layout to consider explicit storage base location #15668

merged 4 commits into from
Mar 8, 2025

Conversation

matheusaaguiar
Copy link
Collaborator

@matheusaaguiar matheusaaguiar commented Dec 20, 2024 •
edited by cameel
Loading

@matheusaaguiar matheusaaguiar self-assigned this Dec 20, 2024
@matheusaaguiar matheusaaguiar changed the base branch from develop to storageLocationsTypeChecking December 20, 2024 19:23
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Jan 4, 2025
@matheusaaguiar matheusaaguiar removed the stale The issue/PR was marked as stale because it has been open for too long. label Jan 4, 2025
@matheusaaguiar matheusaaguiar force-pushed the storageLocationsTypeChecking branch from 82b5fec to 54451ed Compare January 13, 2025 19:04
@matheusaaguiar matheusaaguiar force-pushed the storageLocationStorageLayout branch from d36f847 to 8dea0d1 Compare January 13, 2025 19:07
@matheusaaguiar matheusaaguiar force-pushed the storageLocationsTypeChecking branch 2 times, most recently from f7f90be to 7473a01 Compare January 17, 2025 15:16
@matheusaaguiar matheusaaguiar mentioned this pull request Jan 17, 2025
Open
@matheusaaguiar matheusaaguiar force-pushed the storageLocationsTypeChecking branch 2 times, most recently from 7a1d6b2 to 6f29b3c Compare January 28, 2025 23:13
@matheusaaguiar matheusaaguiar force-pushed the storageLocationStorageLayout branch from 8dea0d1 to 3c6b290 Compare January 29, 2025 02:30
@cameel cameel added the has dependencies The PR depends on other PRs that must be merged first label Jan 31, 2025
@ethereum ethereum deleted a comment from github-actions bot Jan 31, 2025
@matheusaaguiar matheusaaguiar force-pushed the storageLocationStorageLayout branch 2 times, most recently from 19af4c4 to 1cd6cd9 Compare February 3, 2025 19:47
@matheusaaguiar
Copy link
Collaborator Author

This change also affects codegen and tests are successful.

@matheusaaguiar matheusaaguiar force-pushed the storageLocationsTypeChecking branch 3 times, most recently from a3e17ed to 3396801 Compare February 7, 2025 15:28
@matheusaaguiar matheusaaguiar force-pushed the storageLocationsTypeChecking branch 6 times, most recently from 54dab60 to 83cdafa Compare February 21, 2025 19:33
@cameel cameel force-pushed the storageLocationsTypeChecking branch 3 times, most recently from 424ab79 to 5224672 Compare February 24, 2025 13:28
@cameel
Copy link
Member

cameel commented Feb 24, 2025

Needs rebase.

@matheusaaguiar matheusaaguiar force-pushed the storageLocationStorageLayout branch from d5fd8dd to 6ee1148 Compare February 28, 2025 04:19
@cameel

This comment was marked as resolved.

Sign in to view
cameel
cameel reviewed Feb 28, 2025
View reviewed changes
@cameel cameel removed the has dependencies The PR depends on other PRs that must be merged first label Feb 28, 2025
@stackenbotten

This comment was marked as resolved.

Sign in to view
@matheusaaguiar matheusaaguiar force-pushed the storageLocationStorageLayout branch from 6e3f5a5 to 82c7f76 Compare March 3, 2025 14:01
cameel
cameel reviewed Mar 3, 2025
View reviewed changes
cameel
cameel reviewed Mar 3, 2025
View reviewed changes
@matheusaaguiar matheusaaguiar force-pushed the storageLocationStorageLayout branch from 69e5a86 to 6c6dfe4 Compare March 3, 2025 18:39
@matheusaaguiar matheusaaguiar force-pushed the storageLocationStorageLayout branch 2 times, most recently from a13d53e to f27af62 Compare March 4, 2025 03:53
cameel
cameel reviewed Mar 4, 2025
View reviewed changes
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good now. There are still a few minor things to clean up and the changelog entry needs to be changed but there are no big issues remaining.

@cameel cameel mentioned this pull request Mar 4, 2025
Open
@cameel
Copy link
Member

cameel commented Mar 4, 2025

Please note that there are also two earlier unresolved comments here.

@matheusaaguiar
Copy link
Collaborator Author

Please note that there are also two earlier unresolved comments here.

@cameel I think I have addressed all the comments now.

cameel
cameel reviewed Mar 5, 2025
View reviewed changes
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that two tests are still missing the layout specifier.

@matheusaaguiar matheusaaguiar force-pushed the storageLocationStorageLayout branch 3 times, most recently from 80b0428 to 0c0c671 Compare March 6, 2025 13:20
@matheusaaguiar matheusaaguiar force-pushed the storageLocationStorageLayout branch from 0c0c671 to 1423298 Compare March 6, 2025 13:30
@cameel cameel mentioned this pull request Mar 6, 2025
Merged
1 task
@cameel cameel merged commit d084819 into develop Mar 8, 2025
74 checks passed
@cameel cameel deleted the storageLocationStorageLayout branch March 8, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameel cameel cameel approved these changes

Assignees

@matheusaaguiar matheusaaguiar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matheusaaguiar @cameel @stackenbotten