Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whisper: Remove v5 #18432

Merged
merged 1 commit into from
Mar 1, 2019
Merged

whisper: Remove v5 #18432

merged 1 commit into from
Mar 1, 2019

Conversation

gballet
Copy link
Member

@gballet gballet commented Jan 11, 2019

On March 1st, 2019 Whisper v5 will be reaching its end of life and be removed from the go-ethereum repository (code will be saved in a separate repository).

This PR is here to collect feedback on the necessary code changes, especially with regards to PSS.

@gballet gballet requested review from nolash and gluk256 January 11, 2019 08:56
@gballet gballet mentioned this pull request Jan 13, 2019
Closed
@nolash nolash mentioned this pull request Feb 7, 2019
Closed
@gballet
Copy link
Member Author

gballet commented Feb 11, 2019

@nolash @gluk256 any feedback on this? The deadline is approaching.

@nolash
Copy link
Contributor

nolash commented Feb 11, 2019 •
edited
Loading

@gballet hey the pss change is already and just recently merged in now by @gluk256 (we needed to go through the code ourselves to make sure that nothing broke). It doesn't depend on whisperv5 anymore.

#19023

Perhaps you can PR just the actual removal of the whisperv5 directory?

Thanks for the reminder.

@gballet gballet changed the title [WIP] whisper: Remove v5 whisper: Remove v5 Feb 13, 2019
@nolash
Copy link
Contributor

nolash commented Feb 25, 2019

approved provided that, as agreed:

I'm aware of Vlad's PR and if it is merged before Friday then I will remove the duplicate stuff on that day.

:)

@gballet gballet force-pushed the remove-whisper-v branch 3 times, most recently from 4547a3e to 45d2e90 Compare March 1, 2019 08:12
@gballet gballet force-pushed the remove-whisper-v branch from 45d2e90 to b83f69d Compare March 1, 2019 08:13
@gballet gballet added this to the 1.9.0 milestone Mar 1, 2019
@nolash nolash self-requested a review March 1, 2019 11:07
@gballet gballet merged commit 729bf36 into ethereum:master Mar 1, 2019
kiku-jw pushed a commit to kiku-jw/go-ethereum that referenced this pull request Mar 29, 2019
@gballet @kiku-jw
whisper: Remove v5 (ethereum#18432)
229cf42
@gzliudan gzliudan mentioned this pull request Nov 13, 2024
Merged
20 tasks
JukLee0ira added a commit to JukLee0ira/XDPoSChain that referenced this pull request Nov 13, 2024
@JukLee0ira
whisper: Remove v5 (ethereum#18432)
9a5fb2a
JukLee0ira added a commit to JukLee0ira/XDPoSChain that referenced this pull request Nov 14, 2024
@JukLee0ira
whisper: Remove v5 (ethereum#18432)
855f3fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gluk256 gluk256 gluk256 approved these changes

@nolash nolash nolash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gballet @nolash @gluk256