Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whisper: flaky v5 test #18420

Closed
nolash opened this issue Jan 9, 2019 · 6 comments
Closed

whisper: flaky v5 test #18420

nolash opened this issue Jan 9, 2019 · 6 comments
Assignees

Comments

@nolash
Copy link
Contributor

nolash commented Jan 9, 2019

@gballet This test has been flaking on Travis for nearly a year to my reckoning:

?       github.com/ethereum/go-ethereum/whisper/shhclient    [no test files]
--- FAIL: TestSimulation (12.28s)
    peer_test.go:196: Test was not complete: timeout 10 seconds.
FAIL

https://travis-ci.org/ethereum/go-ethereum/jobs/477291221

I briefly ran this by @gluk256 and he said this belongs to v5 which by now perhaps is obsolete. If so, maybe the test is obsolete too, and should be skipped?

@gballet
Copy link
Member

gballet commented Jan 10, 2019

Funny, I've never seen this one fail in travis. I'll have a look into it thanks. I don't want to remove a test, but we should remove v5 altogether. I will warn again and remove it.

@nolash
Copy link
Contributor Author

nolash commented Jan 10, 2019

Ok. However please keep in mind that pss uses v5 as library (not the network, so the sim is not relevant for this). Our v6 port would have to be done prior to removing it.

@gballet
Copy link
Member

gballet commented Jan 13, 2019

I am aware, which is why I requested your review in #18432. Please review it when you get a chance.

@gballet
Copy link
Member

gballet commented Jan 13, 2019

If you believe that my fix isn't going to work, we can also remove everything but what you need, but I would prefer not having dangling bits of code.

@gballet gballet self-assigned this Jan 14, 2019
@nonsense
Copy link
Member

FYI this is still failing on master occasionally.

@gballet
Copy link
Member

gballet commented Mar 18, 2019

Whisper v5 has been removed on March the 1st, closing.

@gballet gballet closed this as completed Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants