-
Notifications
You must be signed in to change notification settings - Fork 20.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
whisper: flaky v5 test #18420
Comments
Funny, I've never seen this one fail in travis. I'll have a look into it thanks. I don't want to remove a test, but we should remove v5 altogether. I will warn again and remove it. |
Ok. However please keep in mind that |
I am aware, which is why I requested your review in #18432. Please review it when you get a chance. |
If you believe that my fix isn't going to work, we can also remove everything but what you need, but I would prefer not having dangling bits of code. |
FYI this is still failing on |
Whisper v5 has been removed on March the 1st, closing. |
@gballet This test has been flaking on Travis for nearly a year to my reckoning:
https://travis-ci.org/ethereum/go-ethereum/jobs/477291221
I briefly ran this by @gluk256 and he said this belongs to
v5
which by now perhaps is obsolete. If so, maybe the test is obsolete too, and should be skipped?The text was updated successfully, but these errors were encountered: