Deprecate CrowdinContributors, GitHubContributors #12969
Conversation
deprecate redundant CrowdinContributors and GitHubContributors components; consolidate logic to gather file contributors list into `utils/contributors.ts` and use to fetch/organize all data in getStaticProps before passing to layout/components.
wackerow
requested review from
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
github-actions
bot
added
content 🖋️
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Great job @wackerow! a very useful refactor.
Left a few minor comments related to the getFileContributorInfo function but nothing blocking.
| locale: string, | ||
| fileLang: string, |
There was a problem hiding this comment.
Is there a scenario where these two are different?
| mdDir: string, | ||
| mdPath: string, | ||
| slug: string, |
There was a problem hiding this comment.
Minor: I see too many args for this function. For example, mdDir and mdPath are derived from slug. Perhaps we could abstract that logic (how to calc mdDir and mdPath) somewhere in the utils and reduce the noise form this function.
IMO, ideally, this function should only require 2 args: slug and locale (the cache is arguable but ok).
| slug: string, | ||
| locale: string, | ||
| fileLang: string, | ||
| layout: Layout, |
There was a problem hiding this comment.
I see we use this arg to determine whether or not we want to fetch the crowdin contributors. Couldn't we deduce this from the slug? slug.includes("/developers/")
Sub-branch PR:
get-static-contributors <- get-static-contributors-consolidationDescription
contributorsthat will be passed to the layout and components from[...slug].tsx.contributors.tsutil file