Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate FileContributors logic #12021

Closed
pettinarip opened this issue Jan 25, 2024 · 3 comments
Closed

Consolidate FileContributors logic #12021

pettinarip opened this issue Jan 25, 2024 · 3 comments
Labels
needs triage 📥 This issue needs triaged before being worked on Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@pettinarip
Copy link
Member

GitHub and Crowdin file contributors components have been updated, but logic is duplicated in the Docs and Tutorials files.

Ideally we have one component that is placed in each of these files that we feed the necessary information to, and then inside that it determines exactly which data to display, rather than having conditional logic that decides whether to render GitHubContributors or CrowdinContributors, and having each of these consume the styling component FileContributors.

cc @wackerow
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jan 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Mar 11, 2024
@github-actions github-actions bot closed this as completed May 8, 2024
@corwintines corwintines reopened this May 9, 2024
@minimalsm minimalsm removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jun 9, 2024
@wackerow
Copy link
Member

Closed with #12969 and #12942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage 📥 This issue needs triaged before being worked on Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pettinarip @corwintines @wackerow @minimalsm