Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-batcher: add channel_queue_length gauge metric #14212

Merged
merged 4 commits into from
Feb 6, 2025

move metric update outside of loop

a5ef9a6
Select commit
Loading
Failed to load commit list.
Merged

op-batcher: add channel_queue_length gauge metric #14212

move metric update outside of loop
a5ef9a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 6, 2025 in 0s

41.32% (-4.40%) compared to 87d8540

View this Pull Request on Codecov

41.32% (-4.40%) compared to 87d8540

Details

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 41.32%. Comparing base (87d8540) to head (a5ef9a6).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
op-batcher/metrics/metrics.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14212      +/-   ##
===========================================
- Coverage    45.71%   41.32%   -4.40%     
===========================================
  Files         1006      841     -165     
  Lines        85916    76617    -9299     
===========================================
- Hits         39278    31663    -7615     
+ Misses       43653    42146    -1507     
+ Partials      2985     2808     -177     
Files with missing lines Coverage Δ
op-batcher/batcher/channel_manager.go 85.84% <100.00%> (+0.26%) ⬆️
op-batcher/metrics/noop.go 86.95% <100.00%> (+0.59%) ⬆️
op-batcher/metrics/test.go 100.00% <100.00%> (ø)
op-batcher/metrics/metrics.go 6.59% <0.00%> (-0.25%) ⬇️

... and 168 files with indirect coverage changes