Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-batcher: add channel_queue_length gauge metric #14212

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

geoknee
Copy link
Contributor

@geoknee geoknee commented Feb 6, 2025

This will be useful in tracking batcher throughput, related to #14109

@geoknee geoknee requested review from a team as code owners February 6, 2025 12:32
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 41.32%. Comparing base (87d8540) to head (a5ef9a6).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
op-batcher/metrics/metrics.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14212      +/-   ##
===========================================
- Coverage    45.71%   41.32%   -4.40%     
===========================================
  Files         1006      841     -165     
  Lines        85916    76617    -9299     
===========================================
- Hits         39278    31663    -7615     
+ Misses       43653    42146    -1507     
+ Partials      2985     2808     -177     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-batcher/batcher/channel_manager.go 85.84% <100.00%> (+0.26%) ⬆️
op-batcher/metrics/noop.go 86.95% <100.00%> (+0.59%) ⬆️
op-batcher/metrics/test.go 100.00% <100.00%> (ø)
op-batcher/metrics/metrics.go 6.59% <0.00%> (-0.25%) ⬇️

... and 168 files with indirect coverage changes

op-batcher/batcher/channel_manager.go Outdated Show resolved Hide resolved
@geoknee geoknee enabled auto-merge February 6, 2025 14:18
@geoknee geoknee added this pull request to the merge queue Feb 6, 2025
Merged via the queue into develop with commit dbf1c04 Feb 6, 2025
46 checks passed
@geoknee geoknee deleted the gk/batcher-channel-q-metric branch February 6, 2025 14:30
alcueca pushed a commit that referenced this pull request Feb 7, 2025
* op-batcher: add channel_queue_length gauge metric

* update NoopMetrics

* integrate new metric behaviour into unit tests

* move metric update outside of loop
alcueca pushed a commit that referenced this pull request Feb 7, 2025
* op-batcher: add channel_queue_length gauge metric

* update NoopMetrics

* integrate new metric behaviour into unit tests

* move metric update outside of loop
alcueca pushed a commit that referenced this pull request Feb 7, 2025
* op-batcher: add channel_queue_length gauge metric

* update NoopMetrics

* integrate new metric behaviour into unit tests

* move metric update outside of loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants