op-node/rollup/derive: Holocene Batch Stage

[sebastianst]

Description

Implements the Holocene BatchStage. It is a new derivation stage that replaces the BatchQueue past-Holocene activation. It shares common code with the BatchQueue via a baseBatchStage.

Needs #12157 to get wired into the derivation pipeline.

❗ Stacked on top of #12497 which needs to be merged first!

Tests

• Added new test cases for checkBatch... behavior with Holocene.
• Parameterized existing applicable BatchQueue tests to also run on the BatchStage. Note that the batch stage is actually simpler than the batch queue because it doesn't queue up batches, so two tests that were specific to queueing behavior don't run on the stage.
• Action tests will be added in the future (Holocene-D: Action Tests #12449) to fully test the BatchStage, especially partial span batch validity.

Additional context

Non-critical follow-ups and observations collected at #12444

Metadata

• closes Holocene-D: Implement Partial Span Batch Validation #11516
• closes Holocene-D: Implement strict batch ordering in channels #12119
• closes Holocene-D: Fix duplicate batch validity caching #11317

[semgrep-app]

Semgrep found 4 sol-style-return-arg-fmt findings:

• packages/contracts-bedrock/scripts/interfaces/IGnosisSafe.sol
  • L79 - Triage
  • L87 - Triage
  • L95 - Triage
  • L103 - Triage

Named return arguments to functions must be appended with an underscore (_)

_{Ignore this finding from sol-style-return-arg-fmt.}

Semgrep found 2 sol-style-malformed-revert findings:

• packages/contracts-bedrock/scripts/deploy/DeployConfig.s.sol
  • L205 - Triage
• packages/contracts-bedrock/scripts/deploy/Deploy.s.sol
  • L1292 - Triage

Malformed revert statement style.

_{Ignore this finding from sol-style-malformed-revert.}

Semgrep found 22 sol-style-input-arg-fmt findings:

• packages/contracts-bedrock/scripts/interfaces/IGnosisSafe.sol
  • L34 - Triage
  • L35 - Triage
  • L38-39 - Triage
  • L46 - Triage
  • L47 - Triage
  • L49 - Triage
  • L50-51 - Triage
  • L65-66 - Triage
  • L80-81 - Triage
  • L88-89 - Triage
  • 12 more - Triage

Inputs to functions must be prepended with an underscore (_)

_{Ignore this finding from sol-style-input-arg-fmt.}

Semgrep found 13 sol-style-malformed-require findings:

• packages/contracts-bedrock/src/cannon/PreimageOracle.sol
  • L100 - Triage
• packages/contracts-bedrock/scripts/periphery/deploy/DeployPeriphery.s.sol
  • L280 - Triage
• packages/contracts-bedrock/scripts/libraries/DeployUtils.sol
  • L207 - Triage
  • L243 - Triage
  • L256 - Triage
• packages/contracts-bedrock/scripts/deploy/DeployOwnership.s.sol
  • L377 - Triage
• packages/contracts-bedrock/scripts/deploy/DeployConfig.s.sol
  • L100 - Triage
• packages/contracts-bedrock/scripts/deploy/Deploy.s.sol
  • L239 - Triage
  • L240 - Triage
• packages/contracts-bedrock/scripts/deploy/ChainAssertions.sol
  • L587 - Triage
• packages/contracts-bedrock/scripts/autogen/SemverLock.s.sol
  • L51 - Triage
• packages/contracts-bedrock/scripts/DeploySuperchain.s.sol
  • L195 - Triage
  • L196 - Triage

"challenge period too large" Malformed require statement style.

_{Ignore this finding from sol-style-malformed-require.}

[semgrep-app]

Semgrep found 3 sol-style-require-reason findings:

• packages/contracts-bedrock/scripts/deploy/Deploy.s.sol
  • L1004 - Triage
  • L1085 - Triage
  • L1092-1095 - Triage

require() must include a reason string

_{Ignore this finding from sol-style-require-reason.}

Semgrep found 1 err-todo finding:

• op-program/client/l2/engineapi/l2_engine_api.go
  • L500 - Triage

TODO in error handling code

_{Ignore this finding from err-todo.}

[ajsutton]

LGTM.