Holocene: initial op-node support for configurable eip-1559 params

[roberto-bayardo]

Description

Implements configurable EIP-1559 parameters in op-node per the Holocene spec: https://github.com/ethereum-optimism/specs/tree/main/specs/protocol/holocene

Full SystemConfig contract updates coming next.

Tests

Unit tests added. E2e test in a followup PR.

[roberto-bayardo]

I've got all the tests passing locally, not sure why those few not passing on the CI. Marking as ready for review, though we'll need to update go.mod to point to the actual op-geth repo once that corresponding PR is merged.

[sebastianst]

Go changes LGTM, but not sure about contract changes.

[tynes]

Looks like some issues with kurtosis in CI

Caused by: Error response from daemon: Conflict. The container name "/kurtosis-fluentbit-configurator" is already in use by container "b25643cf545354883bfe8017c2d776d53c39765a2d6e0e4025a55155e872ac33". You have to remove (or rename) that container to be able to reuse that name.

[tynes]

CRIT [10-18|14:51:21.606] error checking deploy config             err="cannot unmarshal deploy config: json: unknown field \"l2GenesisBlockExtraData\"

The l2GenesisBlockExtraData needs to be removed from any JSON files now that it is removed from the DeployConfig, a git grep -rin l2GenesisBlockExtraData will find them

[roberto-bayardo]

CRIT [10-18|14:51:21.606] error checking deploy config             err="cannot unmarshal deploy config: json: unknown field \"l2GenesisBlockExtraData\"

The l2GenesisBlockExtraData needs to be removed from any JSON files now that it is removed from the DeployConfig, a git grep -rin l2GenesisBlockExtraData will find them

done

[tynes]

Looks like something is wrong with the op-deployer-integration

Caused by: Error response from daemon: Conflict. The container name "/kurtosis-fluentbit-configurator" is already in use by container "b25643cf545354883bfe8017c2d776d53c39765a2d6e0e4025a55155e872ac33". You have to remove (or rename) that container to be able to reuse that name.

Perhaps there is a way to not spin up that image, a previous PR added a timestamp to the image names to prevent this problem, or if its required maybe we can also use a timestamp with its name?

cc @mslipper

[tynes]

Looks like a flake in the e2e tests

=== FAIL: op-e2e/system/altda TestBatcherConcurrentAltDARequests (18.09s)

   concurrent_test.go:76: Expected at least 10 transactions from the batcher
    setup.go:424: CLOSING
    service.go:289:             INFO [10-18|17:10:21.002] Stopping Proposer                        role=proposer
    driver.go:197:              INFO [10-18|17:10:21.002] Stopping Proposer                        role=proposer
    driver.go:473:              INFO [10-18|17:10:21.002] loop returning                           role=proposer
    driver.go:211:              INFO [10-18|17:10:21.002] Proposer stopped                         role=proposer
    service.go:335:             INFO [10-18|17:10:21.002] L2Output Submitter stopped               role=proposer
    service.go:399:             INFO [10-18|17:10:21.002] Stopping batcher                         role=batcher
    driver.go:169:              INFO [10-18|17:10:21.002] Stopping Batch Submitter                 role=batcher
    driver.go:617:              ERROR[10-18|17:10:21.003] Failed to post input to Alt DA           role=batcher error="Post \"http://127.0.0.1:35229/put\": context canceled"

Going to rerun and see if it fixes it

[sebastianst]

Looks like something is wrong with the op-deployer-integration

Caused by: Error response from daemon: Conflict. The container name "/kurtosis-fluentbit-configurator" is already in use by container "b25643cf545354883bfe8017c2d776d53c39765a2d6e0e4025a55155e872ac33". You have to remove (or rename) that container to be able to reuse that name.

Perhaps there is a way to not spin up that image, a previous PR added a timestamp to the image names to prevent this problem, or if its required maybe we can also use a timestamp with its name?

cc @mslipper

Tracking here #12535

[tynes]

Looks like something is wrong with the op-deployer-integration

Caused by: Error response from daemon: Conflict. The container name "/kurtosis-fluentbit-configurator" is already in use by container "b25643cf545354883bfe8017c2d776d53c39765a2d6e0e4025a55155e872ac33". You have to remove (or rename) that container to be able to reuse that name.

Perhaps there is a way to not spin up that image, a previous PR added a timestamp to the image names to prevent this problem, or if its required maybe we can also use a timestamp with its name?
cc @mslipper

Tracking here #12535

This has been fixed on develop, so a rebase will fix the issue

[mslipper]

I merged in latest develop - this should be green now. Good to merge as soon as Adrian's latest comment is addressed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.86%. Comparing base (76c1e1d) to head (4ff4d65).
Report is 8 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #12497      +/-   ##
===========================================
- Coverage    65.04%   64.86%   -0.18%     
===========================================
  Files           54       54              
  Lines         4460     4460              
===========================================
- Hits          2901     2893       -8     
- Misses        1382     1391       +9     
+ Partials       177      176       -1     

Flag	Coverage Δ
cannon-go-tests	64.86% <ø> (-0.18%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes