-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sequencer): Origin Selector asynchronously prefetches the next origin from events #12134
feat(sequencer): Origin Selector asynchronously prefetches the next origin from events #12134
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12134 +/- ##
========================================
Coverage 74.97% 74.97%
========================================
Files 49 49
Lines 3656 3656
========================================
Hits 2741 2741
Misses 743 743
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. |
fcd895e
to
87f0317
Compare
87f0317
to
bec9b29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry for the delay in reviewing.
445a3d4
…rigin from events (ethereum-optimism#12134) * Sequencer: Origin Selector optimistically prefetches the next origin in background * L1OriginSelector erases cached state on reset * L1OriginSelector attempts to fetch on ForkchoiceUpdateEvent * Move to a fully event-driven model, no extra goroutines * Add missing test comment * Minor cleanup, more tests * Tune the context timeouts
Description
Updates the Sequencer's L1 origin selector to locally cache the
currentOrigin
andnextOrigin
attributes and also optimistically prefetch thenextOrigin
whenever anForkchoiceUpdateEvent
event is received. This is expected to remove synchronous origin selection from the critical path of sequencer block production, although the impact of this is reduced when using a single-threaded event loop. (Addressed by #11100)In many cases, the existing L1 origin is "good enough" for building a new block from the sequencer's perspective, and it's better to fetch the next L1 origin in the background instead of spending precious time that could otherwise be used for building the next block. Whenever the
nextOrigin
is already available and valid, this is returned instead.Under specific circumstances, such as when a new L1 origin has not been found for a long period of time, the sequencer will actually need to review the
nextOrigin
and determine if this is valid (behind the next L2 block time). In these cases, theFindL1Origin
call will fetch the next possible origin synchronously, and compare these potential origins immediately.Note: This is a simplified version of #12073, which uses no goroutines and fully embraces the async event model.
Tests
Added several new origin selector tests to ensure that this new prefetching behavior is safe under all conditions.
Metadata
Partially addresses #11960. In order to fully resolve this ticket, we may need to merge the origin selector and attributes builder, so that an origin is only selected if and only if it also has the relevant attributes already built or has all of the data needed to build attributes (L1 receipts).