Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: parallel events executor #11100

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

protolambda
Copy link
Contributor

Description

This adds a new event executor: parallel deriver execution.
Events are queued up, with a customizable capacity per deriver.
A parallel go routine per deriver then dequeues events, and processes them.

Each deriver has its own thread, creating parallelism, but with local state per deriver we simplify a lot of interactions still; no need for locking per individual variable.

This depends on #11099

TODO:

  • Parallel executor unit testing
  • Make it the default for all op-e2e tests to use the parallel executor (except for action testing)
  • Add hidden/beta CLI config flag to op-node to switch to this executor
  • Review race conditions / locks of derivers, to make sure parallel deriver execution is safe

Experimental

Tests

Work in progress.

Metadata

Fix #10864

Base automatically changed from event-system to develop July 9, 2024 07:19
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 8, 2024
@protolambda protolambda removed the Stale label Aug 8, 2024
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@protolambda
Copy link
Contributor Author

Still hoping to pick this work back up once other interop related work cools down

Copy link
Contributor

github-actions bot commented Sep 7, 2024

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@maurelian
Copy link
Contributor

maurelian commented Feb 6, 2025

@protolambda I see that you added the exempt stale label to this. But it's now extremely stale, can it be closed?

Actually I see that you referenced this PR from #13752 as something you still want to get in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-exempt-stale Status: Do not mark stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

op-node: parallel event execution
2 participants