Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add comments for clientv3test.TestWatchResumeInitRev #16888

Merged
merged 3 commits into from
Dec 16, 2023
Merged

tests: add comments for clientv3test.TestWatchResumeInitRev #16888

merged 3 commits into from
Dec 16, 2023

Conversation

greenmoon55
Copy link
Contributor

Fixes #16867

@jmhbnz jmhbnz requested a review from lavacat November 8, 2023 19:05
Copy link

@lavacat lavacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small comments.

@greenmoon55
Copy link
Contributor Author

@lavacat I updated the pr and fixed the go fmt error.

@jmhbnz
Copy link
Member

jmhbnz commented Nov 28, 2023

/ok-to-test

@greenmoon55
Copy link
Contributor Author

Do I need another approval?

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @greenmoon55

Gentle ping @ahrtr for merge.

@ahrtr ahrtr merged commit f7be2df into etcd-io:main Dec 16, 2023
@greenmoon55 greenmoon55 deleted the greenmoon55-patch-1 branch December 22, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Improve comments for clientv3test.TestWatchResumeInitRev
5 participants