Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve comments for clientv3test.TestWatchResumeInitRev #16867

Closed
lavacat opened this issue Nov 6, 2023 · 4 comments · Fixed by #16888
Closed

Improve comments for clientv3test.TestWatchResumeInitRev #16867

lavacat opened this issue Nov 6, 2023 · 4 comments · Fixed by #16888
Assignees
@greenmoon55
Labels
area/testing contribfest Issues for Contribfest workshop happening during KubeCon type/cleanup

Comments

@lavacat
Copy link

lavacat commented Nov 6, 2023

What would you like to be added?

Please review the test and provide summary at the beginning of the test.

Why is this needed?

improving readability
@lavacat lavacat added area/testing type/cleanup contribfest Issues for Contribfest workshop happening during KubeCon labels Nov 6, 2023
@jmhbnz jmhbnz mentioned this issue Nov 7, 2023
Closed
2 tasks
@greenmoon55
Copy link
Contributor

Would like to work on this!

@greenmoon55
Copy link
Contributor

@jmhbnz In TestWatchResumeInitRev, does revision starts from 1 so we expect 4 here?

etcd/tests/integration/clientv3/watch_test.go

Line 371 in 7e00a1e

if resp, ok := <-wch; !ok || resp.Header.Revision != 4 {

@greenmoon55
Copy link
Contributor

Shouldn't we expect 3 here if the start revision is 1?

@greenmoon55 greenmoon55 mentioned this issue Nov 8, 2023
Merged
@greenmoon55
Copy link
Contributor

Nevermind, I got it. Created a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greenmoon55 greenmoon55

Labels
area/testing contribfest Issues for Contribfest workshop happening during KubeCon type/cleanup
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: add comments for clientv3test.TestWatchResumeInitRev
2 participants
@greenmoon55 @lavacat