Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPI Full Duplex DMA test #1443

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Apr 16, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

Add SPI Full Duplex DMA tests

As with AES DMA, I tried to use Context as with other tests, but Rust compiler just wasn't happy with the types and all the movements of them, so I ended up copy/pasting it all over, which makes it really ugly.

Testing

Tested locally on C3, C6, H2 and S3.

Manually triggered the HIL workflow: https://github.com/esp-rs/esp-hal/actions/runs/8701948778

@SergioGasquez SergioGasquez added the skip-changelog No changelog modification needed label Apr 16, 2024
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev enabled auto-merge April 16, 2024 10:26
@MabezDev MabezDev added this pull request to the merge queue Apr 16, 2024
Merged via the queue into esp-rs:main with commit 6b74296 Apr 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants