-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check more #131
Check more #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One small question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! I also tested --all-combinations
and seems to detect all the variants (eg: c3 lists the following options)
""
"alloc"
"alloc, ble, defmt, embassy, esp-backtrace, unstable-hal"
"alloc, ble, defmt, embassy, esp-backtrace, unstable-hal, wifi"
"alloc, ble, defmt, embassy, unstable-hal"
"alloc, ble, defmt, embassy, unstable-hal, wifi"
"alloc, ble, defmt, esp-backtrace, unstable-hal"
"alloc, ble, defmt, esp-backtrace, unstable-hal, wifi"
"alloc, ble, defmt, unstable-hal"
"alloc, ble, defmt, unstable-hal, wifi"
"alloc, ble, embassy, esp-backtrace, log, unstable-hal"
"alloc, ble, embassy, esp-backtrace, log, unstable-hal, wifi"
"alloc, ble, embassy, esp-backtrace, unstable-hal"
"alloc, ble, embassy, esp-backtrace, unstable-hal, wifi"
"alloc, ble, embassy, log, unstable-hal"
"alloc, ble, embassy, log, unstable-hal, wifi"
"alloc, ble, embassy, unstable-hal"
"alloc, ble, embassy, unstable-hal, wifi"
"alloc, ble, esp-backtrace, log, unstable-hal"
"alloc, ble, esp-backtrace, log, unstable-hal, wifi"
"alloc, ble, esp-backtrace, unstable-hal"
"alloc, ble, esp-backtrace, unstable-hal, wifi"
"alloc, ble, log, unstable-hal"
"alloc, ble, log, unstable-hal, wifi"
"alloc, ble, unstable-hal"
"alloc, ble, unstable-hal, wifi"
"alloc, defmt"
"alloc, defmt, embassy, esp-backtrace, unstable-hal"
"alloc, defmt, embassy, esp-backtrace, unstable-hal, wifi"
"alloc, defmt, embassy, unstable-hal"
"alloc, defmt, embassy, unstable-hal, wifi"
"alloc, defmt, esp-backtrace"
"alloc, defmt, esp-backtrace, unstable-hal"
"alloc, defmt, esp-backtrace, unstable-hal, wifi"
"alloc, defmt, unstable-hal"
"alloc, defmt, unstable-hal, wifi"
"alloc, embassy, esp-backtrace, log, unstable-hal"
"alloc, embassy, esp-backtrace, log, unstable-hal, wifi"
"alloc, embassy, esp-backtrace, unstable-hal"
"alloc, embassy, esp-backtrace, unstable-hal, wifi"
"alloc, embassy, log, unstable-hal"
"alloc, embassy, log, unstable-hal, wifi"
"alloc, embassy, unstable-hal"
"alloc, embassy, unstable-hal, wifi"
"alloc, esp-backtrace"
"alloc, esp-backtrace, log"
"alloc, esp-backtrace, log, unstable-hal"
"alloc, esp-backtrace, log, unstable-hal, wifi"
"alloc, esp-backtrace, unstable-hal"
"alloc, esp-backtrace, unstable-hal, wifi"
"alloc, log"
"alloc, log, unstable-hal"
"alloc, log, unstable-hal, wifi"
"alloc, unstable-hal"
"alloc, unstable-hal, wifi"
"defmt"
"defmt, embassy, esp-backtrace, unstable-hal"
"defmt, embassy, unstable-hal"
"defmt, esp-backtrace"
"defmt, esp-backtrace, unstable-hal"
"defmt, unstable-hal"
"embassy, esp-backtrace, log, unstable-hal"
"embassy, esp-backtrace, unstable-hal"
"embassy, log, unstable-hal"
"embassy, unstable-hal"
"esp-backtrace"
"esp-backtrace, log"
"esp-backtrace, log, unstable-hal"
"esp-backtrace, unstable-hal"
"log"
"log, unstable-hal"
"unstable-hal"
Closes #130