Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check more #131

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Check more #131

merged 3 commits into from
Feb 21, 2025

Conversation

bjoernQ
Copy link
Collaborator

@bjoernQ bjoernQ commented Feb 20, 2025

Closes #130

@bjoernQ bjoernQ added the skip-changelog No changelog modification needed label Feb 20, 2025
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small question

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! I also tested --all-combinations and seems to detect all the variants (eg: c3 lists the following options)

""
"alloc"
"alloc, ble, defmt, embassy, esp-backtrace, unstable-hal"
"alloc, ble, defmt, embassy, esp-backtrace, unstable-hal, wifi"
"alloc, ble, defmt, embassy, unstable-hal"
"alloc, ble, defmt, embassy, unstable-hal, wifi"
"alloc, ble, defmt, esp-backtrace, unstable-hal"
"alloc, ble, defmt, esp-backtrace, unstable-hal, wifi"
"alloc, ble, defmt, unstable-hal"
"alloc, ble, defmt, unstable-hal, wifi"
"alloc, ble, embassy, esp-backtrace, log, unstable-hal"
"alloc, ble, embassy, esp-backtrace, log, unstable-hal, wifi"
"alloc, ble, embassy, esp-backtrace, unstable-hal"
"alloc, ble, embassy, esp-backtrace, unstable-hal, wifi"
"alloc, ble, embassy, log, unstable-hal"
"alloc, ble, embassy, log, unstable-hal, wifi"
"alloc, ble, embassy, unstable-hal"
"alloc, ble, embassy, unstable-hal, wifi"
"alloc, ble, esp-backtrace, log, unstable-hal"
"alloc, ble, esp-backtrace, log, unstable-hal, wifi"
"alloc, ble, esp-backtrace, unstable-hal"
"alloc, ble, esp-backtrace, unstable-hal, wifi"
"alloc, ble, log, unstable-hal"
"alloc, ble, log, unstable-hal, wifi"
"alloc, ble, unstable-hal"
"alloc, ble, unstable-hal, wifi"
"alloc, defmt"
"alloc, defmt, embassy, esp-backtrace, unstable-hal"
"alloc, defmt, embassy, esp-backtrace, unstable-hal, wifi"
"alloc, defmt, embassy, unstable-hal"
"alloc, defmt, embassy, unstable-hal, wifi"
"alloc, defmt, esp-backtrace"
"alloc, defmt, esp-backtrace, unstable-hal"
"alloc, defmt, esp-backtrace, unstable-hal, wifi"
"alloc, defmt, unstable-hal"
"alloc, defmt, unstable-hal, wifi"
"alloc, embassy, esp-backtrace, log, unstable-hal"
"alloc, embassy, esp-backtrace, log, unstable-hal, wifi"
"alloc, embassy, esp-backtrace, unstable-hal"
"alloc, embassy, esp-backtrace, unstable-hal, wifi"
"alloc, embassy, log, unstable-hal"
"alloc, embassy, log, unstable-hal, wifi"
"alloc, embassy, unstable-hal"
"alloc, embassy, unstable-hal, wifi"
"alloc, esp-backtrace"
"alloc, esp-backtrace, log"
"alloc, esp-backtrace, log, unstable-hal"
"alloc, esp-backtrace, log, unstable-hal, wifi"
"alloc, esp-backtrace, unstable-hal"
"alloc, esp-backtrace, unstable-hal, wifi"
"alloc, log"
"alloc, log, unstable-hal"
"alloc, log, unstable-hal, wifi"
"alloc, unstable-hal"
"alloc, unstable-hal, wifi"
"defmt"
"defmt, embassy, esp-backtrace, unstable-hal"
"defmt, embassy, unstable-hal"
"defmt, esp-backtrace"
"defmt, esp-backtrace, unstable-hal"
"defmt, unstable-hal"
"embassy, esp-backtrace, log, unstable-hal"
"embassy, esp-backtrace, unstable-hal"
"embassy, log, unstable-hal"
"embassy, unstable-hal"
"esp-backtrace"
"esp-backtrace, log"
"esp-backtrace, log, unstable-hal"
"esp-backtrace, unstable-hal"
"log"
"log, unstable-hal"
"unstable-hal"

@SergioGasquez SergioGasquez added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 64b16e9 Feb 21, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI does not cover all the options
2 participants