Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI does not cover all the options #130

Closed
SergioGasquez opened this issue Feb 20, 2025 · 2 comments · Fixed by #131
Closed

CI does not cover all the options #130

SergioGasquez opened this issue Feb 20, 2025 · 2 comments · Fixed by #131
Assignees
@bjoernQ
Milestone
esp-generate for ...

Comments

@SergioGasquez
Copy link
Member

SergioGasquez commented Feb 20, 2025 •
edited
Loading

The following options are being checked:

  • empty, alloc, defmt, esp-backtrace, log, unstable-hal
    We are missing:
  • wifi, ble, embassy, probe-rs, flashing-probe-rs/defmt, flashing-probe-rs/panic-rtt-target/, flashing-espflash/log, flashing-espflash/demft, flashing-espflash/esp-backtrace

Originally posted by @SergioGasquez in #129 (comment)
@bjoernQ
Copy link
Collaborator

bjoernQ commented Feb 20, 2025

Given how fast we can do the checks now we can definitely afford to test more

@SergioGasquez SergioGasquez mentioned this issue Feb 20, 2025
Merged
@SergioGasquez
Copy link
Member Author

The --all-combinations is not checking embassy at all, neither. So probably we are also missing lots of options there

@bjoernQ bjoernQ mentioned this issue Feb 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjoernQ bjoernQ

Labels
None yet
Projects
esp-rs
Archived in project
Milestone
esp-generate for [email protected]
Development

Successfully merging a pull request may close this issue.

Check more esp-rs/esp-generate
2 participants
@bjoernQ @SergioGasquez