-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devcontainer extensions #111
Conversation
Not sure what to do with https://github.com/esp-rs/esp-generate/blob/main/template/.devcontainer/devcontainer.json#L28-L32, shall we duplicate the settings on |
mhhh not sure (and I never used a dev-container) but having different settings is not great I guess btw would you mind to duplicate the recommended extensions in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
I updated them to be the same in both files, hopefully those are not changed and stay the same in both places |
See #109 (review)