Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer extensions #111

Merged
merged 5 commits into from
Feb 12, 2025

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez
Copy link
Member Author

Not sure what to do with https://github.com/esp-rs/esp-generate/blob/main/template/.devcontainer/devcontainer.json#L28-L32, shall we duplicate the settings on .vscode?

@bjoernQ
Copy link
Collaborator

bjoernQ commented Feb 12, 2025

Not sure what to do with https://github.com/esp-rs/esp-generate/blob/main/template/.devcontainer/devcontainer.json#L28-L32, shall we duplicate the settings on .vscode?

mhhh not sure (and I never used a dev-container) but having different settings is not great I guess

btw would you mind to duplicate the recommended extensions in .vscode/extensions.json? If we recommend extensions we should also do that for local projects

Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@SergioGasquez
Copy link
Member Author

mhhh not sure (and I never used a dev-container) but having different settings is not great I guess

I updated them to be the same in both files, hopefully those are not changed and stay the same in both places

@SergioGasquez SergioGasquez added this pull request to the merge queue Feb 12, 2025
Merged via the queue into esp-rs:main with commit 7233527 Feb 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants