Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated vscode extension in devcontainer config #109

Conversation

legas7
Copy link
Contributor

@legas7 legas7 commented Feb 11, 2025

Doing recommended migration of crates to dependi vscode extension.

@legas7 legas7 force-pushed the update-deprecated-vscode-extension-devcontainer branch from 19987b6 to 0f7d8b9 Compare February 11, 2025 16:21
Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We probably should review the other extensions and also have them for the local VSCode settings

e.g. Wokwi only makes sense when Wokwi support is selected.

Some of the recommendations are pretty much unnecessary IMHO

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I agree with @bjoernQ we should review the other extensions, but that can be done in another PR

@SergioGasquez SergioGasquez added this pull request to the merge queue Feb 12, 2025
Merged via the queue into esp-rs:main with commit a927531 Feb 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants