Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support derived addresses from public key on read-only mode #32

Closed
arobsn opened this issue Aug 25, 2021 · 1 comment · Fixed by #92
Closed

Support derived addresses from public key on read-only mode #32

arobsn opened this issue Aug 25, 2021 · 1 comment · Fixed by #92
Labels
enhancement New feature or request

Comments

@arobsn
Copy link
Member

arobsn commented Aug 25, 2021

In order to have a smoother experience between the Ergo's wallets, it would be great if a way to derive addresses from the wallet's Extended Public Key was implemented by reading its QR Code.

  • Yoroi provides the public key at Settings > Wallet > Export.
  • Ergo Paper Wallet also provides the same key on the printed wallet.

It would be nice for these users could securely track their balances through this feature.
@MrStahlfelge MrStahlfelge added the enhancement New feature or request label Aug 30, 2021
@MrStahlfelge MrStahlfelge mentioned this issue Sep 9, 2021
Closed
15 tasks
@MrStahlfelge MrStahlfelge mentioned this issue Feb 5, 2022
Merged
@MrStahlfelge
Copy link
Member

MrStahlfelge commented Feb 15, 2022 •
edited
Loading

  • Add xpubkey to db scheme
  • Make add read only screen support using xpubkey (and save it for later use)
  • Support deriving addresses from xpubkey
  • Add way to show xpubkey in wallet config screen

MrStahlfelge added a commit that referenced this issue Feb 15, 2022
@MrStahlfelge
DB schema change for xpubkey support #32
a34cbc6
MrStahlfelge added a commit that referenced this issue Feb 15, 2022
@MrStahlfelge
Make add read only screen support using xpubkey #32
24f0dc2
MrStahlfelge added a commit that referenced this issue Feb 15, 2022
@MrStahlfelge
DB schema change for xpubkey missing field assignment #32
fc43d22
MrStahlfelge added a commit that referenced this issue Feb 15, 2022
@MrStahlfelge
Support deriving addresses from xpubkey #32
67388b6
MrStahlfelge added a commit that referenced this issue Feb 16, 2022
@MrStahlfelge
Android display xpubkey #32 introduces ShareWithQrDialogFragment and …
23b5e8c 
…WalletConfigUiLogic
MrStahlfelge added a commit that referenced this issue Feb 16, 2022
@MrStahlfelge
iOS display xpubkey #32 introduces ShareWithQrCodeViewController
c3c0d8e
@MrStahlfelge MrStahlfelge mentioned this issue Feb 16, 2022
Merged
@MrStahlfelge MrStahlfelge mentioned this issue Mar 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@MrStahlfelge @arobsn and others