Add methods to serialize and deserialize an extended public key according to bip-32 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding to bip-32 and to derive eip3 addresses from such a key
MrStahlfelge
force-pushed
the
xpubserialization
branch
from
9a3bf0e to
2cfee45
Compare
aslesarenko
requested changes
Feb 7, 2022
| @@ -173,14 +174,35 @@ public static Address createEip3Address( | |||
| // Let's use "m/44'/429'/0'/0/index" path (this path is compliant with EIP-3 which | |||
| // is BIP-44 for Ergo) | |||
| DerivationPath path = JavaHelpers.eip3DerivationWithLastIndex(index); | |||
| ExtendedSecretKey secretKey = (ExtendedSecretKey)rootSecret.derive(path); | |||
| ExtendedSecretKey secretKey = (ExtendedSecretKey) rootSecret.derive(path); | |||
There was a problem hiding this comment.
I guess the method below can be reused here to avoid code cloning.
| new DerivationPath((Seq) Constants.eip3DerivationPath().decodedPath().dropRight(1), | ||
| true)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Serializaition roundtrip tests are necessary. See for example https://github.com/ScorexFoundation/sigmastate-interpreter/blob/9e1467ce0a4e981e64246aaeffc35a2efe053978/sigmastate/src/test/scala/org/ergoplatform/ErgoAddressSpecification.scala#L29
…ding to bip-32 and to derive eip3 addresses from such a key
aslesarenko
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added method to derive eip3 addresses from such a key
Needed for ergoplatform/ergo-wallet-app#32